feat: gas + coverage report workflows #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gas1cent
reviewed
Mar 8, 2024
Comment on lines
18
to
25
| - name: Checkout Repo | ||
| uses: actions/checkout@v3 | ||
|
|
||
| - name: Setup Node.js | ||
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: 18.x | ||
| cache: 'yarn' |
There was a problem hiding this comment.
Could you upgrade those actions to v4? See an example here: https://github.com/defi-wonderland/solidity-foundry-boilerplate/blob/main/.github/workflows/release.yml#L18-L31
There was a problem hiding this comment.
And the same in the other action
gas1cent
reviewed
Mar 8, 2024
Comment on lines
14
to
15
| generate-gas-report: | ||
| name: Generate Foundry Gas Reports |
There was a problem hiding this comment.
Let's please shorten the names a bit to "Gas Reports" and "Test Coverage"
xorsal
pushed a commit
that referenced
this pull request
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes BES-1, BES-2