-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add IERC7802 #123
feat: add IERC7802 #123
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,11 @@ | ||
// SPDX-License-Identifier: MIT | ||
pragma solidity ^0.8.0; | ||
|
||
/// @title ICrosschainERC20 | ||
import { IERC165 } from "@openzeppelin/contracts/interfaces/IERC165.sol"; | ||
|
||
/// @title IERC7802 | ||
/// @notice Defines the interface for crosschain ERC20 transfers. | ||
interface ICrosschainERC20 { | ||
interface IERC7802 is IERC165 { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. if you include it here, do you need to include in the implementation contract as well? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This one is for the interface to enforce it to be included when extending from it The other one is an abstract contract that has the OZ implementation, it particularly declares supporting the One solution is to stop inheriting from |
||
/// @notice Emitted when a crosschain transfer mints tokens. | ||
/// @param to Address of the account tokens are being minted for. | ||
/// @param amount Amount of tokens minted. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cant we make the
IERC7802
includeIERC165
?