Skip to content

Commit

Permalink
keys
Browse files Browse the repository at this point in the history
  • Loading branch information
dgodinez-dh committed Dec 13, 2024
1 parent bd3ea49 commit 33a88de
Showing 1 changed file with 67 additions and 0 deletions.
67 changes: 67 additions & 0 deletions plugins/ui/docs/describing/render_lists.md
Original file line number Diff line number Diff line change
Expand Up @@ -84,3 +84,70 @@ my_content_list = content_list(food, "vegetable")
```

![my_content_list2](../_assets/render_lists2.png)

## Keep list items in order with keys

Keys tell `deephaven.ui` which list item each component corresponds to, so that it can match them up later. This becomes important if your list items can move (e.g. due to sorting), get inserted, or get deleted. A well-chosen key helps `deephaven.ui` infer what exactly has happened, and make the correct updates.

Rather than generating keys on the fly, you should include them in your data.

### Where to get your key

Different sources of data provide different sources of keys:

- Data from a database: If your data is coming from a database, you can use the database keys/IDs, which are unique by nature.
- Locally generated data: If your data is generated and persisted locally, use an incrementing counter or a package like `uuid` when creating items.

### Rules of keys

- Keys must be unique among siblings. However, it is okay to use the same keys for items in different lists.
- Keys must not change. Do not generate them while rendering.

In this example, the `ui_cells` component can add cell which can be deleted. The line `key=str(i)` is commented out, so the cell components do not have keys. If the user tries to delete a cell in the middle of the component, the last cell will be deleted instead. Comment in the line that sets the key. Now the correct cell will be deleted.

```python
from deephaven import ui
import itertools


@ui.component
def ui_cell(label="Cell"):
text, set_text = ui.use_state("")
return ui.text_field(label=label, value=text, on_change=set_text)


@ui.component
def ui_deletable_cell(i, delete_cell):
return ui.flex(
ui_cell(label=f"Cell {i}"),
ui.action_button(
ui.icon("vsTrash"),
aria_label="Delete cell",
on_press=lambda: delete_cell(i),
),
align_items="end",
# comment in this line to fix
# key=str(i),
)


@ui.component
def ui_cells():
id_iter, set_id_iter = ui.use_state(lambda: itertools.count())
cells, set_cells = ui.use_state(lambda: [next(id_iter)])

def add_cell():
set_cells(lambda old_cells: old_cells + [next(id_iter)])

def delete_cell(delete_id: int):
set_cells(lambda old_cells: [c for c in old_cells if c != delete_id])

return ui.view(
[ui_deletable_cell(i, delete_cell) for i in cells],
ui.action_button(ui.icon("vsAdd"), "Add cell", on_press=add_cell),
overflow="auto",
)


cells = ui_cells()
```

0 comments on commit 33a88de

Please sign in to comment.