Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for PreRecorded #50

Merged
merged 10 commits into from
Jul 17, 2023
Merged

Add tests for PreRecorded #50

merged 10 commits into from
Jul 17, 2023

Conversation

Weimw
Copy link
Contributor

@Weimw Weimw commented Jul 3, 2023

Proposed changes

Add simple unit tests for prerecorded.go. Introduce dependency on httpmock(https://pkg.go.dev/github.com/jarcoal/httpmock)

Types of changes

What types of changes does your code introduce to the community Go SDK?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ x] Documentation update or tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [x ] I have read the CONTRIBUTING doc
  • [ x] Lint and unit tests pass locally with my changes
  • [ x] I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@Weimw Weimw requested a review from SandraRodgers July 3, 2023 21:25
update enhance in tier to enhanced

Co-authored-by: Sandra Rodgers <[email protected]>
@Weimw Weimw requested a review from SandraRodgers July 17, 2023 16:18
tests/prerecorded_test.go Outdated Show resolved Hide resolved
tests/prerecorded_test.go Outdated Show resolved Hide resolved
tests/prerecorded_test.go Outdated Show resolved Hide resolved
tests/prerecorded_test.go Outdated Show resolved Hide resolved
tests/prerecorded_test.go Outdated Show resolved Hide resolved
@Weimw Weimw requested a review from SandraRodgers July 17, 2023 17:00
@SandraRodgers SandraRodgers merged commit 63c2386 into deepgram:main Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants