-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix README: pass options as pointers #250
Conversation
WalkthroughThe recent changes involve altering the declarations of the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- README.md (2 hunks)
Additional context used
LanguageTool
README.md
[duplication] ~7-~7: Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Context: ...eech understanding API. - Deepgram Go SDK - SDK Documentation - [G...
[style] ~32-~32: This phrase is redundant (‘I’ stands for ‘Interfaces’). Use simply “APIInterfaces”. (ACRONYM_TAUTOLOGY)
Context: ...ram-go-sdk@main/pkg/api/live/v1) - Live API Interfaces - [https://pkg.go.dev/github.com/deepgr...
[style] ~38-~38: This phrase is redundant (‘I’ stands for ‘Interfaces’). Use simply “APIInterfaces”. (ACRONYM_TAUTOLOGY)
Context: ...n/pkg/api/prerecorded/v1) - PreRecorded API Interfaces - [https://pkg.go.dev/github.com/deepgr...
[style] ~44-~44: This phrase is redundant (‘I’ stands for ‘Interfaces’). Use simply “APIInterfaces”. (ACRONYM_TAUTOLOGY)
Context: ...m-go-sdk@main/pkg/api/speak/v1) - Speak API Interfaces - [https://pkg.go.dev/github.com/deepgr...
[style] ~50-~50: This phrase is redundant (‘I’ stands for ‘Interfaces’). Use simply “APIInterfaces”. (ACRONYM_TAUTOLOGY)
Context: ...-sdk@main/pkg/api/analyze/v1) - Analyze API Interfaces - [https://pkg.go.dev/github.com/deepgr...
[style] ~56-~56: This phrase is redundant (‘I’ stands for ‘Interfaces’). Use simply “APIInterfaces”. (ACRONYM_TAUTOLOGY)
Context: ...go-sdk@main/pkg/api/manage/v1) - Manage API Interfaces -[https://pkg.go.dev/github.com/deepgra...
[uncategorized] ~76-~76: A comma may be missing after the conjunctive/linking adverb ‘However’. (SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA)
Context: ... clients shouldn't need to know about. However you can still tweak options and setting...
[misspelling] ~147-~147: Use “a” instead of ‘an’ if the following word doesn’t start with a vowel sound, e.g. ‘a sentence’, ‘a university’. (EN_A_VS_AN)
Context: ...amples/prerecorded/file/main.go) - From an URL - [examples/prerecorded/url](https:...
[duplication] ~157-~157: Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Context: ... Save audio to a Path - examples/speak/save - Save audio to a user-defined Writer - [examp...
[uncategorized] ~171-~171: A comma might be missing here. (AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
Context: ...ples/manage/usage/main.go) To run each example set theDEEPGRAM_API_KEY
as an enviro...
[style] ~175-~175: To make your writing clearer, consider a more direct alternative. (AS_A_MEANS_TO)
Context: ... ## Logging This SDK provides logging as a means to troubleshoot and debug issues encountered. By defaul...
[style] ~175-~175: In American English, abbreviations like “etc.” require a period. (ETC_PERIOD)
Context: ...ages and higher (ieWarning
,Error
, etc) when you initialize the library as fol...
[uncategorized] ~206-~206: A comma might be missing here. (AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
Context: ... ### Getting Help We love to hear from you so if you have questions, comments or f...
[style] ~207-~207: This expression usually appears with a “please” in front of it. (INSERT_PLEASE)
Context: ... comments or find a bug in the project, let us know! You can either: - [Open an issue in t...
Additional comments not posted (2)
README.md (2)
91-91
: Documentation Update: Passing Options as PointersThe change correctly updates the
options
variable to be a pointer toPreRecordedTranscriptionOptions
. This aligns with the expected API usage and helps prevent potential issues with mutable shared state.
111-111
: Documentation Update: Update to Pointer for Live Transcription OptionsThis change updates the
transcriptOptions
variable to be a pointer. This modification is consistent with the API's expectations and ensures that the example in the README is correct and up-to-date.
Nice catch @jhillyerd ! |
Proposed changes
Update README examples to pass option structs as pointers, as is expected by
the API.
Types of changes
What types of changes does your code introduce to the community Go SDK?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Summary by CodeRabbit