Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: implementation of sortField and sortOrder fields #980

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

ApMatheus
Copy link
Contributor

What is this contribution about?

Solution to the problem with intermittent responses to Konfidency reviews on PDP

Provide a brief description of the changes or improvements you are proposing in this pull request.
As analyzed in the Konfidency documentation, we found a problem in the request on [product evaluation endPoint], where previously the sortField and sortOrder values ​​were not passed, resulting in a lack of evaluation data

Loom video

https://www.loom.com/share/602525ae12d94b239a2d2cad7adf08ab?sid=4725c5cd-f9de-44ca-a4a8-a9202efb983e

Copy link
Contributor

Tagging Options

Should a new tag be published when this PR is merged?

  • 👍 for Patch 0.64.11 update
  • 🎉 for Minor 0.65.0 update
  • 🚀 for Major 1.0.0 update

Copy link
Contributor

@viktormarinho viktormarinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@viktormarinho viktormarinho merged commit 54379b3 into deco-cx:main Dec 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants