Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use the dynamic locale prop #957

Merged
merged 4 commits into from
Dec 3, 2024
Merged

use the dynamic locale prop #957

merged 4 commits into from
Dec 3, 2024

Conversation

marcoferreiradev
Copy link
Contributor

What is this Contribution About?

Please provide a brief description of the changes or enhancements you are proposing in this pull request.

Issue Link

Please link to the relevant issue that this pull request addresses:

Loom Video

Record a quick screencast describing your changes to help the team understand and review your contribution. This will greatly assist in the review process.

Demonstration Link

Provide a link to a branch or environment where this pull request can be tested and seen in action.

@github-actions GitHub Actions
Copy link
Contributor

Tagging Options

Should a new tag be published when this PR is merged?

  • 👍 for Patch 0.63.1 update
  • 🎉 for Minor 0.64.0 update
  • 🚀 for Major 1.0.0 update

matheusgr
matheusgr requested changes Nov 19, 2024
View reviewed changes
vtex/loaders/intelligentSearch/productDetailsPage.ts Outdated Show resolved Hide resolved
vtex/loaders/intelligentSearch/productListingPage.ts Outdated Show resolved Hide resolved
vtex/loaders/intelligentSearch/productList.ts Outdated Show resolved Hide resolved
@matheusgr matheusgr merged commit f0e4ca5 into main Dec 3, 2024
1 check passed
@matheusgr matheusgr deleted the feat/curren-locale branch December 3, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matheusgr matheusgr matheusgr approved these changes

Assignees
No one assigned
Labels
needs review vtex VTEX App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcoferreiradev @matheusgr @guitavano