Library should not contains lockfile #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This makes sense to me 👍 |
|
Hmm. Yeah good points all around. Can you add to .gitignore and .npmignore please @fengmk2 ? |
fengmk2
force-pushed
the
remove-lockfile
branch
from
4e4b2b8 to
310ae22
Compare
|
@thebigredgeek Added! |
|
@fengmk2 thanks merging. As a note, if you are using Yarn, use pure mode to avoid caching in lockfiles |
|
@thebigredgeek yep, I know how yarn work. |
|
Kk. Just trying to be helpful :D. I didn't know about that option until I read up more on it. Been busy with work. Started using Yarn to simply save time during build debugging haha |
|
Yep, yarn install is very fast after lockfile created. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://medium.com/@boennemann/avoid-yarn-for-packages-and-fully-enjoy-its-benefits-for-application-development-8bdd4deb33cf