Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBZ-8479 Improve DDL parsing logic #217

Merged
merged 3 commits into from
Dec 5, 2024
Merged

Conversation

twthorn
Copy link
Contributor

@twthorn twthorn commented Dec 2, 2024

A few changes to make this DDL logic more fault tolerant

  1. Only parse DDLs if that schema history is enabled (otherwise this is unnecessary work)
  2. Strip comments to ensure we parse correctly
  3. Make table & type fault tolerant so we gracefully handle cases where we didn't parse either

Also fix DBZ-8432

Also dockerfile failing with the apt-key statement so remove that as it's unnecessary

@twthorn
Copy link
Contributor Author

twthorn commented Dec 2, 2024

@jpechane Can you take a look when you get the chance? Thank you

@jpechane jpechane merged commit 8c7fb7c into debezium:main Dec 5, 2024
3 checks passed
@jpechane
Copy link
Contributor

jpechane commented Dec 5, 2024

@twthorn Applied, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants