Move health checks to a separate function in bats test file #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now, regarding to the template file, we have to write checks twice: - In `@test "install from directory"` - And in `@test "install from release"` - the same lines. Will be good to move that to a separate function, to not have two places to manage them. So, I've created a function `health_checks()` that contains only a single instance of checks. And have moved it to the top, because it will be edited more frequiently, than test functions.
1 task
rfay
requested changes
Mar 31, 2023
|
Seems |
rfay
approved these changes
Apr 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, regarding to the template file, we have to write checks twice:
@test "install from directory"@test "install from release"- the same lines.Will be good to move that to a separate function, to not have two places to manage them.
So, I've created a function
health_checks()that contains only a single instance of checks.And have moved it to the top, because it will be edited more frequiently, than test functions.