This repository has been archived by the owner on Jun 5, 2020. It is now read-only.
Bump glob version to address https://nodesecurity.io/advisories/118 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Path: metascript > glob > minimatch - Also bumped jsDoc version which faced build issues initially.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The jsDoc related changes don't have many meaningful changes. Just needed to bump the version to properly build the docs, for which there are no real changes (its all cosmetic). If you'd rather not merge the doc changes, let me know.
Main issue reason for this PR is to move off the old
globversion which used a version ofminimatchwith a major security flaw. Granted this is a development dependency, but with how the NPM deduplication logic goes, it pays to be safe. API was identical, so no code changes required.