migrate setup.py to pyproject.toml #1465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @deronnax , this has been overdue for some time. CI is not happy with the change though, do you think you could figure this out, or need help? Our CI workflow is pretty simple, so I'm surprised there's been a hiccup: https://github.com/dbcli/pgcli/blob/main/.github/workflows/ci.yml but perhaps we're missing something there. |
dbaty
reviewed
May 22, 2024
deronnax
force-pushed
the
mdupuy/-/migrate-to-pyproject-toml
branch
from
41c8be9 to
e647319
Compare
dbaty
reviewed
Jun 4, 2024
deronnax
force-pushed
the
mdupuy/-/migrate-to-pyproject-toml
branch
from
a0d71f3 to
9284371
Compare
deronnax
force-pushed
the
mdupuy/-/migrate-to-pyproject-toml
branch
from
9284371 to
94c0911
Compare
|
All concerns addressed. Sorry for the oversights. |
|
@j-bennet let's merge ? |
|
@deronnax Yes! thanks for the ping. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following PEP 621, setup.py is soft-deprecated (not truly deprecated but not the way to go anymore) and metadata in pyproject.toml is the new norm. This change should be functionally strictly equivalent.
Checklist
changelog.rst.AUTHORSfile (or it's already there).pip install pre-commit && pre-commit install), and ranblackon my code.