Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stores): variable k was not getting passed #110

Merged
merged 1 commit into from
Aug 12, 2023

Conversation

mirkancal
Copy link
Contributor

@mirkancal mirkancal commented Aug 12, 2023

  • Description: I noticed always 4 documents were returned from search. Seems like it wasn't get passed to similaritySearch, maxMarginalRelevanceSearch.
  • Tag maintainer: @davidmigloz

Maintainer responsibilities:

See contribution guidelines for more information on how to write/run tests, lint, etc:
https://github.com/davidmigloz/langchain_dart/blob/main/CONTRIBUTING.md

@davidmigloz davidmigloz self-requested a review August 12, 2023 13:01
@davidmigloz davidmigloz added this to the v0.0.6 milestone Aug 12, 2023
@davidmigloz davidmigloz merged commit 80e61eb into davidmigloz:main Aug 12, 2023
@davidmigloz
Copy link
Owner

Good catch and thanks for the fix @mirkancal 🙂
Merged!

@davidmigloz davidmigloz added t:bug Something isn't working c:vector-stores Vector stores. labels Aug 13, 2023
KennethKnudsen97 pushed a commit to KennethKnudsen97/langchain_dart that referenced this pull request Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:vector-stores Vector stores. t:bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants