Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Supabase VectorStore #69

Closed
davidmigloz opened this issue Jul 11, 2023 · 10 comments · Fixed by #318
Closed

Add support for Supabase VectorStore #69

davidmigloz opened this issue Jul 11, 2023 · 10 comments · Fixed by #318
Assignees
Labels
c:vector-stores Vector stores. t:enhancement New feature or request
Milestone

Comments

@davidmigloz
Copy link
Owner

davidmigloz commented Jul 11, 2023

supabase/supabase-flutter#489 (comment)

https://cookbook.openai.com/examples/vector_databases/supabase/readme

@davidmigloz davidmigloz converted this from a draft issue Jul 11, 2023
@davidmigloz davidmigloz added t:enhancement New feature or request c:vector-stores Vector stores. labels Jul 11, 2023
@davidmigloz davidmigloz moved this from 📆 Planned to 📋 Backlog in LangChain.dart Aug 7, 2023
@matteodg
Copy link
Contributor

matteodg commented Jan 6, 2024

Hi @davidmigloz , I'd like to take care of this task, is that OK?

matteodg added a commit to matteodg/langchain_dart that referenced this issue Jan 6, 2024
matteodg added a commit to matteodg/langchain_dart that referenced this issue Jan 6, 2024
@davidmigloz
Copy link
Owner Author

davidmigloz commented Jan 6, 2024

Hey @matteodg !

Thanks for your interest in contributing 🙂

@luisredondo was going to start working on it (not sure if he started implementing it already), but I see you already made quite some progress so go for it!

@davidmigloz
Copy link
Owner Author

davidmigloz commented Jan 6, 2024

Actually, @luisredondo is telling me that he already started implementing it as well (my bad, I didn't update the ticket). It'd be good to try to sync/merge your changes and his changes. Are you in the LangChain.dart Discord @matteodg? We can discuss it in the #contributing channel.

@luisredondo
Copy link
Contributor

Hey @matteodg! I have been researching how to implement this appropriately and can offer some input if needed. We can sync via Discord. @davidmigloz provided the link above. You already made a good amount of progress, so I don't mind if you take over it. But here I am if you need a hand!

@matteodg
Copy link
Contributor

matteodg commented Jan 7, 2024

Hi @luisredondo! I'm basically converting to Dart from the Python LangChain (but actually the JS one might be a better source, easier for me at least as I'm more a Java dev). Let me know any input you have or any work you already have done. Thanks!

matteodg added a commit to matteodg/langchain_dart that referenced this issue Jan 7, 2024
matteodg added a commit to matteodg/langchain_dart that referenced this issue Jan 7, 2024
@davidmigloz davidmigloz moved this from 📋 Backlog to 🏗 In Progress in LangChain.dart Jan 8, 2024
matteodg added a commit to matteodg/langchain_dart that referenced this issue Jan 9, 2024
matteodg added a commit to matteodg/langchain_dart that referenced this issue Jan 9, 2024
matteodg added a commit to matteodg/langchain_dart that referenced this issue Jan 9, 2024
@matteodg
Copy link
Contributor

matteodg commented Jan 9, 2024

I found a few inconsistencies between Python LangChain and the JS one:

I used the JS LangChain definition for the moment.

matteodg added a commit to matteodg/langchain_dart that referenced this issue Jan 28, 2024
matteodg added a commit to matteodg/langchain_dart that referenced this issue Jan 28, 2024
matteodg added a commit to matteodg/langchain_dart that referenced this issue Jan 28, 2024
matteodg added a commit to matteodg/langchain_dart that referenced this issue Jan 28, 2024
matteodg added a commit to matteodg/langchain_dart that referenced this issue Jan 28, 2024
matteodg added a commit to matteodg/langchain_dart that referenced this issue Jan 28, 2024
matteodg added a commit to matteodg/langchain_dart that referenced this issue Jan 28, 2024
@matteodg
Copy link
Contributor

Hi @davidmigloz and @luisredondo, the PR is ready for you to review!

I slightly changed the match_documents functions: it now contains also the match_threshold (see the blog entry Storing OpenAI embeddings in Postgres with pgvector), so we can filter the results by threshold directly in Supabase instead of filtering them locally.

matteodg added a commit to matteodg/langchain_dart that referenced this issue Jan 28, 2024
@davidmigloz
Copy link
Owner Author

@matteodg awesome, thank you very much!

Can you open a PR from your repo to this repo?
I'll review it tomorrow

@matteodg
Copy link
Contributor

Here it is #318

davidmigloz pushed a commit to matteodg/langchain_dart that referenced this issue Jan 31, 2024
davidmigloz pushed a commit to matteodg/langchain_dart that referenced this issue Jan 31, 2024
davidmigloz added a commit that referenced this issue Jan 31, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ✅ Done in LangChain.dart Jan 31, 2024
@davidmigloz davidmigloz modified the milestones: v0.4.0, v0.4.1 Jan 31, 2024
KennethKnudsen97 pushed a commit to KennethKnudsen97/langchain_dart that referenced this issue Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:vector-stores Vector stores. t:enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants