Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically add CAN_MANAGE permission on databricks_instance_pool to calling user #2298

Merged
merged 1 commit into from
May 22, 2023

Conversation

nkvuong
Copy link
Contributor

@nkvuong nkvuong commented May 12, 2023

Changes

Closes #2238

Tests

Tests locally

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@codecov-commenter
Copy link

Codecov Report

Merging #2298 (947c136) into master (28cbf48) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2298   +/-   ##
=======================================
  Coverage   88.72%   88.72%           
=======================================
  Files         140      140           
  Lines       11551    11551           
=======================================
  Hits        10249    10249           
  Misses        869      869           
  Partials      433      433           
Impacted Files Coverage Δ
permissions/resource_permissions.go 89.62% <ø> (ø)

@nkvuong nkvuong force-pushed the fix/pool-permissions branch from 947c136 to 12e3138 Compare May 17, 2023 10:22
@nkvuong nkvuong marked this pull request as ready for review May 17, 2023 10:30
@nkvuong nkvuong requested review from a team May 17, 2023 10:31
Copy link
Contributor

@alexott alexott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nfx nfx merged commit a255f5c into master May 22, 2023
@nfx nfx deleted the fix/pool-permissions branch May 22, 2023 18:51
@nfx nfx mentioned this pull request May 22, 2023
nfx added a commit that referenced this pull request May 22, 2023
 * **Removed support for releasing 32-bit binaries** ([#2315](#2315), [#2320](#2320)).
 * Added more information on impact of using a cluster policy in [databricks_cluster](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/cluster) resource ([#2313](#2313)).
 * Added missing `serverless` option to [databricks_pipeline](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/pipeline) ([#2308](#2308)).
 * Updated `channel` and `edition` values in [databricks_pipeline](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/pipeline) docs ([#2322](#2322)).
 * Automatically add `CAN_MANAGE` permission on [databricks_instance_pool](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/instance_pool) for calling user ([#2298](#2298)).
 * Migrated [databricks_ip_access_list](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/ip_access_list) resource to Go SDK ([#2306](#2306)).

Updated dependency versions:

 * Bump github.com/stretchr/testify from 1.8.2 to 1.8.3 ([#2317](#2317)).
 * Bump github.com/databricks/databricks-sdk-go from v0.8.1 to v0.9.0 ([#2327](#2327)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ISSUE] Ownership is removed before permissions are deleted
4 participants