Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update databricks_sql_table doc #2281

Merged
merged 1 commit into from
May 10, 2023
Merged

Conversation

bradfordchang
Copy link
Contributor

Changes

Fixes sql_table example in documentation to use name from databricks_catalog and databricks_schema instead of id.

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@codecov-commenter
Copy link

Codecov Report

Merging #2281 (da5dd28) into master (eac7007) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2281   +/-   ##
=======================================
  Coverage   88.72%   88.72%           
=======================================
  Files         140      140           
  Lines       11550    11550           
=======================================
  Hits        10248    10248           
  Misses        869      869           
  Partials      433      433           

@nkvuong nkvuong self-requested a review May 10, 2023 07:32
Copy link
Contributor

@nkvuong nkvuong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for the contribution

@nkvuong nkvuong changed the title Update sql_table doc examples so they work Update databricks_sql_table doc May 10, 2023
@nfx nfx merged commit 46a3262 into databricks:master May 10, 2023
@bradfordchang bradfordchang deleted the docfix branch May 10, 2023 13:25
nfx added a commit that referenced this pull request May 12, 2023
# Version changelog

## 1.16.0

 * Added [databricks_workspace_file](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/workspace_file) resource ([#2266](#2266)).
 * Added `notification_settings` block to [databricks_job](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/job) resource ([#2276](#2276)).
 * Added missing permission to [databricks_aws_crossaccount_policy](https://registry.terraform.io/providers/databricks/databricks/latest/docs/data-sources/aws_crossaccount_policy) data source ([#2283](#2283)).
 * Fixed [databricks_sql_table](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/sql_table) doc ([#2281](#2281)).
 * Fixed doc on tag propagation and tag conflict for [databricks_instance_pool](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/instance_pool) resource ([#2242](#2242)).
 * Document & export [databricks_workspace_conf](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/workspace_conf) parameters for legacy init scripts ([#2280](#2280)).
 * Removed deprecated `CREATE_VIEW` from code of [databricks_grants](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/grants) resource ([#2230](#2230)).
 * Exporter: relax handling of problematic files/directories ([#2258](#2258)).
@nfx nfx mentioned this pull request May 12, 2023
nfx added a commit that referenced this pull request May 12, 2023
# Version changelog

## 1.16.0

 * Added [databricks_workspace_file](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/workspace_file) resource ([#2266](#2266)).
 * Added `notification_settings` block to [databricks_job](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/job) resource ([#2276](#2276)).
 * Added missing permission to [databricks_aws_crossaccount_policy](https://registry.terraform.io/providers/databricks/databricks/latest/docs/data-sources/aws_crossaccount_policy) data source ([#2283](#2283)).
 * Fixed [databricks_sql_table](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/sql_table) doc ([#2281](#2281)).
 * Fixed doc on tag propagation and tag conflict for [databricks_instance_pool](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/instance_pool) resource ([#2242](#2242)).
 * Document & export [databricks_workspace_conf](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/workspace_conf) parameters for legacy init scripts ([#2280](#2280)).
 * Removed deprecated `CREATE_VIEW` from code of [databricks_grants](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/grants) resource ([#2230](#2230)).
 * Exporter: relax handling of problematic files/directories ([#2258](#2258)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants