Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove note about Azure KeyVault-based secret scopes and service principals #2231

Merged
merged 2 commits into from
Apr 26, 2023

Conversation

alexott
Copy link
Contributor

@alexott alexott commented Apr 18, 2023

Changes

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@alexott alexott requested review from a team April 18, 2023 17:55
@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2023

Codecov Report

Merging #2231 (9405517) into master (c282084) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2231   +/-   ##
=======================================
  Coverage   88.74%   88.74%           
=======================================
  Files         137      137           
  Lines       11290    11290           
=======================================
  Hits        10019    10019           
  Misses        855      855           
  Partials      416      416           

@alexott
Copy link
Contributor Author

alexott commented Apr 20, 2023

azure-prod acceptance test passed

internal/acceptance/secret_scope_test.go Outdated Show resolved Hide resolved
internal/acceptance/secret_scope_test.go Outdated Show resolved Hide resolved
@alexott alexott force-pushed the akv-secret-scope-warning-removal branch from 9405517 to 4b89f5e Compare April 24, 2023 17:52
@alexott alexott requested review from nfx and a team April 24, 2023 17:52
@alexott alexott force-pushed the akv-secret-scope-warning-removal branch from 4b89f5e to be31322 Compare April 24, 2023 17:53
@nfx nfx merged commit eb63228 into master Apr 26, 2023
@nfx nfx deleted the akv-secret-scope-warning-removal branch April 26, 2023 10:29
@nfx nfx mentioned this pull request May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants