Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add history_data_sharing_status, partition and status fields to databricks_share #2013

Merged
merged 2 commits into from
Feb 16, 2023

Conversation

nkvuong
Copy link
Contributor

@nkvuong nkvuong commented Feb 16, 2023

This time closes #2004 properly

@nkvuong
Copy link
Contributor Author

nkvuong commented Feb 16, 2023

acceptance tests passed

@nkvuong nkvuong marked this pull request as ready for review February 16, 2023 11:56
@nkvuong nkvuong requested review from a team February 16, 2023 11:56
@codecov-commenter
Copy link

Codecov Report

Merging #2013 (266f2aa) into master (ccb7f86) will decrease coverage by 0.02%.
The diff coverage is 33.33%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2013      +/-   ##
==========================================
- Coverage   90.35%   90.33%   -0.02%     
==========================================
  Files         146      146              
  Lines       11908    11911       +3     
==========================================
+ Hits        10759    10760       +1     
- Misses        742      743       +1     
- Partials      407      408       +1     
Impacted Files Coverage Δ
catalog/resource_share.go 94.87% <33.33%> (-2.47%) ⬇️

@nfx nfx merged commit 6c943f0 into master Feb 16, 2023
@nfx nfx deleted the delta-sharing-share branch February 16, 2023 12:12
@nfx nfx mentioned this pull request Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add support for Partitions, CDF & History for databricks_share
3 participants