Removed check for creation of Azure Key Vault-based databricks_secret_scope using Service Principals
#1965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n Databricks. It seems MSFT now fixed this issue. This commit removes the control that checks if the principal calling this is a Service Principal and throws an error.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1965 +/- ##
=======================================
Coverage 90.29% 90.30%
=======================================
Files 146 146
Lines 11906 11895 -11
=======================================
- Hits 10751 10742 -9
+ Misses 746 745 -1
+ Partials 409 408 -1
|
mattiazenidb
changed the title
mattiazenidb
changed the title
alexott
changed the title
databricks_secret_scope using Service Principals
alexott
requested changes
Jan 30, 2023
nfx
changed the title
databricks_secret_scope using Service Principalsdatabricks_secret_scope using Service Principals
nfx
approved these changes
Jan 30, 2023
Merged
michael-berk
pushed a commit
to michael-berk/terraform-provider-databricks
that referenced
this pull request
Feb 15, 2023
…t_scope` using Service Principals (databricks#1965) * With Service Principals was never possible to create a Secret Scope in Databricks. It seems MSFT now fixed this issue. This commit removes the control that checks if the principal calling this is a Service Principal and throws an error. * Removed unused function kvDiffFunc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the check that was forbidding to call this from a Service Principal since it was not working. Now that MSFT fixed it we can remove the check and allow customers use it.