Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made lifetime_seconds & comment optional for databricks_obo_token #1844

Merged
merged 3 commits into from
Dec 14, 2022

Conversation

nkvuong
Copy link
Contributor

@nkvuong nkvuong commented Dec 13, 2022

Close #1810

Copy link
Contributor

@alexott alexott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nfx nfx changed the title make lifetime_seconds & comment optional for databricks_obo_token Made lifetime_seconds & comment optional for databricks_obo_token Dec 14, 2022
@nfx nfx enabled auto-merge (squash) December 14, 2022 13:17
@codecov-commenter
Copy link

Codecov Report

Merging #1844 (2600090) into master (e9bcc2d) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1844   +/-   ##
=======================================
  Coverage   90.15%   90.15%           
=======================================
  Files         142      142           
  Lines       11363    11363           
=======================================
  Hits        10244    10244           
  Misses        711      711           
  Partials      408      408           
Impacted Files Coverage Δ
tokens/resource_obo_token.go 100.00% <ø> (ø)

@nfx nfx merged commit 10397d9 into master Dec 14, 2022
@fuselessmatt
Copy link
Contributor

Great stuff!

@nfx : When do you think you will publish this (a new version of the provider)? It has been a month since last time

@nfx nfx mentioned this pull request Dec 14, 2022
@nkvuong nkvuong deleted the fix/obo_token branch January 4, 2023 12:30
michael-berk pushed a commit to michael-berk/terraform-provider-databricks that referenced this pull request Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ISSUE] Issue with databricks_obo_token - Disabling token expiration is not possible?
6 participants