Improve test coverage of multitask jobs & DLT pipelines #1493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1493 +/- ##
==========================================
+ Coverage 89.68% 90.24% +0.55%
==========================================
Files 129 129
Lines 10405 10405
==========================================
+ Hits 9332 9390 +58
+ Misses 694 646 -48
+ Partials 379 369 -10
|
|
@alexott could you also increase the coverage of exporter/util.go to 90%? |
nfx
requested changes
Jul 22, 2022
|
Not this time, primary things that aren't covered are error handling in the complex conditions... |
|
Complex conditions are more likely to break. If you’re concerned about the size of testing code - look at how individual Imports on importables are tested. There is a special helper to test for what is emitted without causing any downstream requests |
|
I’m not concerned about testing code size, I’m concerned about my time for that. Feel free to to revert previous PR. |
nfx
approved these changes
Jul 25, 2022
Merged
michael-berk
pushed a commit
to michael-berk/terraform-provider-databricks
that referenced
this pull request
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.