Fixed databricks_table update for column block
#1468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexott
reviewed
Jul 18, 2022
| if !d.HasChange(field) { | ||
|
|
||
| var old, new interface{} | ||
| if field == "columns" { |
There was a problem hiding this comment.
wouldn't it be simpler to do:
if field == "columns" {
field = "column"
}
old, new = d.GetChange(field)
if !d.HasChange(field) {
continue
}
There was a problem hiding this comment.
the API expect columns in the payload however
catalog/update.go
Outdated
| } | ||
|
|
||
| //ignore storage_location for MANAGED tables | ||
| if field == "storage_location" && d.Get("table_type") != "EXTERNAL" { |
There was a problem hiding this comment.
shouldn't it be handled as suppress diff?
Also, should we handle the case when people will change from managed to external?
There was a problem hiding this comment.
table_type cannot be updated
Codecov Report
@@ Coverage Diff @@
## master #1468 +/- ##
=======================================
Coverage 90.11% 90.12%
=======================================
Files 126 126
Lines 10208 10218 +10
=======================================
+ Hits 9199 9209 +10
Misses 642 642
Partials 367 367
|
nfx
changed the title
databricks_table update for column block
nfx
changed the title
databricks_table update for column blockdatabricks_table update for column block
Merged
michael-berk
pushed a commit
to michael-berk/terraform-provider-databricks
that referenced
this pull request
Feb 15, 2023
* fix and simplify update table logic * fix managed table update logic * add suppress_diff to table location
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1455
There must be a more programmatic way to do this...