Fix job_cluster.num_workers in databricks_job
#1284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply standard schema modification rules to `num_workers` field in shared job clusters. Fix #1262
Codecov Report
@@ Coverage Diff @@
## master #1284 +/- ##
=======================================
Coverage 90.57% 90.57%
=======================================
Files 118 118
Lines 9970 9971 +1
=======================================
+ Hits 9030 9031 +1
Misses 559 559
Partials 381 381
|
Merged
pietern
reviewed
May 9, 2022
| @@ -450,6 +450,7 @@ var jobSchema = common.StructToSchema(JobSettings{}, | |||
| func(s map[string]*schema.Schema) map[string]*schema.Schema { | |||
| jobSettingsSchema(&s, "") | |||
| jobSettingsSchema(&s["task"].Elem.(*schema.Resource).Schema, "task.0.") | |||
| jobSettingsSchema(&s["job_cluster"].Elem.(*schema.Resource).Schema, "job_cluster.0.") | |||
There was a problem hiding this comment.
What about jobs with multiple tasks?
I assume .0. is a proxy for .N.?
michael-berk
pushed a commit
to michael-berk/terraform-provider-databricks
that referenced
this pull request
Feb 15, 2023
Apply standard schema modification rules to `num_workers` field in shared job clusters. Fix databricks#1262
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply standard schema modification rules to
num_workersfield in shared job clusters.Fix #1262