Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a new selector for spark versions and node types #1127

Merged
merged 1 commit into from
Feb 17, 2022

Conversation

alexott
Copy link
Contributor

@alexott alexott commented Feb 17, 2022

No description provided.

@alexott alexott requested a review from nfx February 17, 2022 10:42
CHANGELOG.md Outdated
@@ -6,6 +6,7 @@
* Fixed issue at `databricks_mount` where new cluster was created for S3 mount even when `cluster_id` was specified ([#1064](https://github.com/databrickslabs/terraform-provider-databricks/issues/1064)).
* Allow to disable auto-termination for Databricks SQL endpoints ([#900](https://github.com/databrickslabs/terraform-provider-databricks/pull/900)).
* Added new `gcp_attributes` to `databricks_cluster` and `databricks_instance_pool` ([#1126](https://github.com/databrickslabs/terraform-provider-databricks/pull/1126)).
* Added exporter functionality for `databricks_ip_access_list` and `databricks_workspace_conf` ([#1125](https://github.com/databrickslabs/terraform-provider-databricks/pull/1125))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: lines must end in period

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and please add a changelog for graviton PR :)

@alexott alexott force-pushed the additional-selectors branch from eac85d2 to 881a7fb Compare February 17, 2022 11:08
@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #1127 (881a7fb) into master (641a3f2) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1127      +/-   ##
==========================================
- Coverage   91.07%   91.06%   -0.02%     
==========================================
  Files         111      111              
  Lines        9618     9622       +4     
==========================================
+ Hits         8760     8762       +2     
- Misses        507      508       +1     
- Partials      351      352       +1     
Impacted Files Coverage Δ
clusters/data_node_type.go 84.50% <0.00%> (-2.45%) ⬇️
clusters/data_spark_version.go 94.54% <100.00%> (+0.10%) ⬆️
workspace/resource_workspace_conf.go 81.25% <100.00%> (+0.29%) ⬆️

@nfx nfx merged commit b5c4fc3 into master Feb 17, 2022
@nfx nfx deleted the additional-selectors branch February 17, 2022 11:14
@nfx nfx mentioned this pull request Feb 18, 2022
michael-berk pushed a commit to michael-berk/terraform-provider-databricks that referenced this pull request Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants