-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: dask.array: asarray(..., copy=None) copies in dask==2024.12 #211
Conversation
Two issues:
|
In the standard for If there is nothing we can do to fix this then I think updating the test is fine. |
Yes, I think it is compatible for Dask to say that they will always copy, and just raise an error for |
The issue with 2024.12 is |
It is compatible for them to always copy with EDIT: the wording in the spec is
and the Dask maintainers appear to be saying 'reusing the existing memory buffer is never possible' (or at least never supported) |
2442a92
to
fda4ab0
Compare
As of dask >= 2024.12, da.from_array() always copies, while before it did not. Thus copy too, to make array_api_compat.dask.array version-independent.
It seems to hang on CI with dask==2024.12
8c3c7dd
to
bce5dcc
Compare
CI is green with three tweaks
|
Co-authored-by: crusaderky <[email protected]>
@lucascolley @rgommers this PR is blocking everything |
Let's unblock everything then :-) |
closes gh-209