Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use default MessageDispatch from SDK, customize it in runtime. #905

Closed
hackfisher opened this issue Jun 8, 2022 · 2 comments
Closed
Assignees

Comments

@hackfisher
Copy link
Contributor

hackfisher commented Jun 8, 2022

It is recommended not to use FromBridgedChainMessageDispatch of runtime-common, instead, each runtime implements it by itself.

  • This default implementation passes a lot of generics and is less readable.
  • According to #103, the default implementation of Darwinia is not used here, but it is easy to misunderstand that the settlement fee is done on the target chain.
  • Each runtime implements its own primitives that are more convenient to obtain external runtimes, e.g. derive_ethereum_account for Ethereum origin.
@boundless-forest
Copy link
Member

This issue looks like in darwinia-common repo scope, should we move it there? @AurevoirXavier

@boundless-forest
Copy link
Member

I think this is solved. Close it.

boundless-forest pushed a commit that referenced this issue Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants