Replace broken Observatory URL with DevTools URL

[kenzieschmoll]

When running a test with dart test foo_test.dart --pause-after-load, the following is printed to the CLI:

 dart test test/dart_test/b_example_test.dart --pause-after-load
...
00:01 +0: loading test/dart_test/b_example_test.dart                                                  
Observatory URL: http://127.0.0.1:51715/1m3AdwIltJ4=/#/inspect?isolateId=isolates%2F3973115144356875&objectId=libraries%2F%4019317648
The test runner is paused. Open the Observatory and set breakpoints. Once you're finished, return to
this terminal and press Enter.

This URL is broken. DevTools is also unavailable from this state because there is not a DDS instance.

We should fix this so that when running a test with dart test for debugging, DevTools is served properly and the user can access if from a URL printed to CLI (Flutter tools does this properly for flutter test).

CC @jakemac53 @bkonyi

[kenzieschmoll]

This is important for the work to support DevTools extensions for dart tests: flutter/devtools#7183.

[bkonyi]

This will require two changes:

1. We need to be able to serve DDS and DevTools from dart test (this currently isn't configured)
2. We need to update something in package:test* to print the right message.

For 1), @a-siva is currently working on a CL to launch DDS (and also serve DevTools) from the VM service isolate instead of from DartDev, so we'll get this for free once that work is done.

For 2), changing the messaging should be easy enough, but I'm not sure we'll be able to mimic the prior behavior since the DevTools debugger doesn't support navigating to a library based on a query parameter like Observatory does.

[kenzieschmoll]

For 2), changing the messaging should be easy enough, but I'm not sure we'll be able to mimic the prior behavior since the DevTools debugger doesn't support navigating to a library based on a query parameter like Observatory does.

I think this is okay. The user can decide what type of debugging they want to do once they get into DevTools.

[bkonyi]

For 2), changing the messaging should be easy enough, but I'm not sure we'll be able to mimic the prior behavior since the DevTools debugger doesn't support navigating to a library based on a query parameter like Observatory does.

I think this is okay. The user can decide what type of debugging they want to do once they get into DevTools.

Sure, but it definitely won't be as user friendly since navigating to the debugger will dump the user in the root library which will be generated code. Not the end of the world (especially considering this link has been broken for over a year now and no one filed an issue), but it's not the ideal UX.

[jakemac53]

I am not worried about losing some behavior today, because it sounds like the current thing doesn't work at all?

[bkonyi]

I am not worried about losing some behavior today, because it sounds like the current thing doesn't work at all?

For sure. Getting something working is better than nothing, but we might want to fix this UX in the future if anyone actually uses it and complains... :-)

[natebosch]

1. We need to be able to serve DDS and DevTools from dart test (this currently isn't configured)

Has this been resolved?

2. We need to update something in package:test* to print the right message.

What is the correct Uri for dev tools generally? If we cannot deep link to the library I think we can resolve that later.

[bkonyi]

1. We need to be able to serve DDS and DevTools from dart test (this currently isn't configured)

Has this been resolved?

It doesn't look like moving the DDS launch logic to the VM service handles the Service.webServerControl(...) flow. We'll need to do that before this will work.

2. We need to update something in package:test* to print the right message.

What is the correct Uri for dev tools generally? If we cannot deep link to the library I think we can resolve that later.

This might be context dependent at this point.

For the standalone VM, the URI is always of the form http://<path>/devtools/debugger?uri=ws://<path>/ws, where path is the address, port, and optional auth code for DDS. That URI will open to the debugger page in DevTools with the main isolate selected; there's currently no way to select isolates via query parameters.

For flutter test, I'm not 100% sure. Right now flutter_tools is spinning up its own DevTools server rather than using the one hosted by DDS. I'm working on changing this to be more consistent with the standalone VM, but that change is currently blocked by some other work.

[bkonyi]

1. We need to be able to serve DDS and DevTools from dart test (this currently isn't configured)

Has this been resolved?

It doesn't look like moving the DDS launch logic to the VM service handles the Service.webServerControl(...) flow. We'll need to do that before this will work.

This will be resolved once https://dart-review.googlesource.com/c/sdk/+/366560 lands.

[bkonyi]

The above CL has landed, so we can now serve DDS and DevTools from dart test.

[kenzieschmoll]

@bkonyi what are the next steps here since https://dart-review.googlesource.com/c/sdk/+/366560 was reverted?

[bkonyi]

That change was relanded last week so work can move forward here.

[natebosch]

When I try this devtools seems to send a resume event as soon as I open the UI in a browser. Is there a way around this? It breaks the test runner workflow.

[natebosch]

@kenzieschmoll is there any way to launch devtools without resuming the VM?