Refactor how Object and Pragma are discovered and handled #3929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for review, @dart-lang/analyzer-team |
scheglov
reviewed
Nov 15, 2024
scheglov
approved these changes
Nov 15, 2024
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Nov 19, 2024
Revisions updated by `dart tools/rev_sdk_deps.dart`. dartdoc (https://github.com/dart-lang/dartdoc/compare/6bbd3d7..f8a55e4): f8a55e4b 2024-11-18 Parker Lougheed Remove unused build config (dart-lang/dartdoc#3923) fa339a10 2024-11-15 Sam Rawlins Refactor how Object and Pragma are discovered and handled (dart-lang/dartdoc#3929) http (https://github.com/dart-lang/http/compare/2f954e1..e37093f): e37093f 2024-11-15 Brian Quinlan Upgrade to `package:`objective_c` 4.0 (dart-lang/http#1406) e509abb 2024-11-14 Slava Egorov Switch browser_client.dart to use fetch (dart-lang/http#1401) yaml_edit (https://github.com/dart-lang/yaml_edit/compare/3d1421b..8bd0fdf): 8bd0fdf 2024-11-18 Kevin Moore Fix unused param in a private ctor lint (dart-lang/yaml_edit#99) Change-Id: I12a74dc3bce629c213d26fbb6e76fc3c19a443dd Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/396422 Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Devon Carew <[email protected]>
felangel
reviewed
Dec 18, 2024
| /// The collection of "special" classes for which we need some special access. | ||
| final specialClasses = SpecialClasses(); | ||
| /// The Object class declared in the Dart SDK's 'dart:core' library. | ||
| late InheritingContainer objectClass; |
There was a problem hiding this comment.
Looks like this broke dartdoc analysis for certain packages (looks like when mixins are used). See #3947
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3927
This may have positive perf implications. While documenting googleapis three times, I see the time to document decrease by 1%-1.8%, and memory seems to be reduced by 0.5%. These numbers could be within the margin of error though. 🤷
Contribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.