Support augmentation-declared constructors and methods. #3712
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gist of this is to not just ask an Element for it's methods and for its constructors, but make sure to ask the augmented element, if there is one.
Work towards #3693
Again, we still cannot check in tests as we cannot depend on
_fe_analyzer_shared
oranalyzer
from the Dart SDK, or use the correct macros import. But with this code, we get the following features:A few fixes are made additionally:
disposed
. So I tidied that all back into PackageBuilder. It can not be the PackageBuilder's caller's responsibility to dispose, because that amounts to have a dozen places in tests.Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.