Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update the darkweak/storages/core dep in sub-modules #10

Closed
wants to merge 1 commit into from

Conversation

mohammed90
Copy link
Contributor

Sorry for missing these from #8 , though it's probably not feasible to do them in the same earlier PR. The sub-modules need to depend on the latest darkweak/storages/core to be able to reference the new fields when built with github.com/darkweak/souin. The earlier PR passed CI because it used the replaces, which are not transitive to downstream as is the case when building them in Souin.

@mohammed90
Copy link
Contributor Author

Will be superseded by #9

@mohammed90 mohammed90 closed this Jul 31, 2024
@mohammed90 mohammed90 deleted the upgrade-core-version branch July 31, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant