feat(chore): storages externalization refactoring #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkweak
added
enhancement
✅ Deploy Preview for teal-sprinkles-4c7f14 canceled.
|
darkweak
force-pushed
the
feat/chore/storages-externalization-refactoring
branch
2 times, most recently
from
fbcbaa6 to
a8b1557
Compare
darkweak
force-pushed
the
feat/chore/nutsdb-bump-and-fix-redis-surrogate
branch
from
46601cc to
40af3c2
Compare
darkweak
force-pushed
the
feat/chore/storages-externalization-refactoring
branch
3 times, most recently
from
2a3cc26 to
284481b
Compare
darkweak
force-pushed
the
feat/chore/storages-externalization-refactoring
branch
from
284481b to
c478f1f
Compare
darkweak
changed the base branch from
feat/chore/nutsdb-bump-and-fix-redis-surrogate
to
master
darkweak
force-pushed
the
feat/chore/storages-externalization-refactoring
branch
from
c478f1f to
9b8e1e5
Compare
darkweak
force-pushed
the
feat/chore/storages-externalization-refactoring
branch
3 times, most recently
from
2598476 to
2cf848e
Compare
darkweak
force-pushed
the
feat/chore/storages-externalization-refactoring
branch
from
2cf848e to
37f0c97
Compare
darkweak
force-pushed
the
feat/chore/storages-externalization-refactoring
branch
2 times, most recently
from
11ade18 to
087ba66
Compare
darkweak
force-pushed
the
feat/chore/storages-externalization-refactoring
branch
2 times, most recently
from
03c620d to
caeb0ee
Compare
darkweak
force-pushed
the
feat/chore/storages-externalization-refactoring
branch
from
caeb0ee to
84b1908
Compare
darkweak
force-pushed
the
feat/chore/storages-externalization-refactoring
branch
3 times, most recently
from
dbf7eb3 to
b74852c
Compare
…age instances concurrently
darkweak
force-pushed
the
feat/chore/storages-externalization-refactoring
branch
from
b74852c to
d7b6d10
Compare
darkweak
force-pushed
the
feat/chore/storages-externalization-refactoring
branch
2 times, most recently
from
8ec4316 to
36f8f84
Compare
darkweak
force-pushed
the
feat/chore/storages-externalization-refactoring
branch
from
36f8f84 to
b68678b
Compare
2024-07-09T08:02:16.526Z-iPad_Pro_landscape.jpeg
|
2024-07-09T13:23:32.359Z-iPad_Pro_landscape.jpeg
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seen with @francislavoie, @mohammed90 and other from the @caddyserver team to externalize the storages as independent modules. This implementation will rely on the https://github.com/darkweak/storages repository that will contain all storages available in the sound codebase. The benefits are to tag only improvements in one storage without tagging the whole HTTP cache system, reduce the binary size and be able to pack only what you need.
By default there is a very simple in-memory cache storage but the eviction doesn't work well. That's only for development and backup purpose.
This creates a big diff but that's mainly move from Souin core to the storage repo.