fixes issue #187 #253
fixes issue #187 #253
Conversation
|
Based on #246 - I'm not sure this will ever be accepted. |
|
@mallardduck This PR is missing tests. I asked the original contributor to add them but I got no answer. |
|
Hi @darccio, sorry for the delay. I've added a couple of test to verify the fix. Also, a slight statement change to take into account the case where you want to override map values even when the source structure fields are empty. |
|
@vsemichev Looks it works and all tests are green. Let's release another v1 version. |
| @@ -58,7 +58,7 @@ func deepMap(dst, src reflect.Value, visited map[uintptr]*visit, depth int, conf | |||
| } | |||
| fieldName := field.Name | |||
| fieldName = changeInitialCase(fieldName, unicode.ToLower) | |||
| if v, ok := dstMap[fieldName]; !ok || (isEmptyValue(reflect.ValueOf(v), !config.ShouldNotDereference) || overwrite) { | |||
| if _, ok := dstMap[fieldName]; !ok || (!isEmptyValue(reflect.ValueOf(src.Field(i).Interface()), !config.ShouldNotDereference) && overwrite) || config.overwriteWithEmptyValue { | |||
There was a problem hiding this comment.
Unfortunately, this change would break our use case, consider the following scenario
dst := map[string]interface{}{
"foo": nil,
"bar": 1,
}
src := struct {
Foo *string
Bar int
}{
Foo: &"hello",
Bar: 42,
}
if err := mergo.Map(&dst, src); err != nil {
t.Error(err)
}we expect *dst["foo"] == "hello" and dst["bar"] == 1
There was a problem hiding this comment.
@frankdvd Your use case seems to be an unintended consequence. Mergo shouldn't flatten structures while mapping.
Hi, this PR will hopefully fix the issue #187 with map destinations for Map method. It's one simple change.