Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoC dedicated process X errors #27

Draft
wants to merge 1 commit into
base: unstable
Choose a base branch
from
Draft

Conversation

dapplion
Copy link
Owner

Currently block process and blob process both return the same BlockError. While convenient there are many variants of BlockError that don't make sense for blob process.

This PR explores having dedicated error types for:

  • ProcessBlockError: returned by process_block (verifies block and calls import_block)
  • ProcessBlobError: returned by process_blob (verifies blob and calls import_block)
  • BlockImportError: returned by import_block

If we want to have a common routine in sync for block component at some level we have to coerce block and blob errors into the same thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant