DAOS-11624 test: Adding support for the Test-storage-tier pragma #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding support for passing the Test-storage-tier build parameter or commit pragma to launch.py via its --storage_tier argument. Signed-off-by: Phil Henderson <[email protected]>
brianjmurrell
previously approved these changes
Dec 12, 2022
vars/parseStageInfo.groovy
Outdated
Comment on lines
319
to
321
| if (ftest_arg_storage_tier) { | ||
| result['ftest_arg'] += ' --storage_tier=' + ftest_arg_storage_tier | ||
| } |
There was a problem hiding this comment.
Worth mentioning that this could be made more succinct with:
Suggested change
| if (ftest_arg_storage_tier) { | |
| result['ftest_arg'] += ' --storage_tier=' + ftest_arg_storage_tier | |
| } | |
| result['ftest_arg'] += ftest_arg_storage_tier ? ' --storage_tier=' + ftest_arg_storage_tier : '' |
Or that a function could be written to make all of this more DRY, now that it's evident that it's proliferating. I.e.
String get_param_or_pragma(param, pragma, arg) {
String res = params.$param ?: cachedCommitPragma(
pragma + result['pragma_suffix'], cachedCommitPragma(pragma, null))
return res ? ' --' + arg + '= ' + res : ''
}
result['ftest_arg'] += get_param_or_pragma('TestStorageTier', 'Test-storage-tier', '--storage_tier')And of course using the above for all of the other param-or-pragma values that are built into result['ftest_arg'].
There was a problem hiding this comment.
Thanks. I've added this change.
Signed-off-by: Phil Henderson <[email protected]>
Signed-off-by: Phil Henderson <[email protected]>
brianjmurrell
previously approved these changes
Dec 13, 2022
Signed-off-by: Phil Henderson <[email protected]>
Signed-off-by: Phil Henderson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for passing the Test-storage-tier build parameter or commit pragma to launch.py via its --storage_tier argument.
Signed-off-by: Phil Henderson [email protected]