DAOS-10535 tests: Install new daos-tests-internal package #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The daos-{client,server}-tests-openmpi packages will no longer be
installed via daos-test requirements. Explicitly install them for CI
testing.
Signed-off-by: Phillip Henderson <[email protected]>
… tests. Signed-off-by: Phillip Henderson <[email protected]>
Signed-off-by: Phillip Henderson <[email protected]>
Comment on lines
28
to
+29
| if (env.TEST_RPMS == 'true') { | ||
| pkgs = "daos{,-{client,tests,server,serialize}" + add_daos_pkgs + "}" | ||
| pkgs = "daos{,-{client,tests-internal,server,serialize}" + add_daos_pkgs + "}" |
There was a problem hiding this comment.
Is this creating an issue that once this is landed, CI will be broken until all DAOS branches and PRs are creating these packages?
There was a problem hiding this comment.
The daos branches will need to be updated to produce this new package first.
There was a problem hiding this comment.
Yes. There is a discussion in the PR starting at https://daosio.atlassian.net/browse/DAOS-10535?focusedCommentId=97808
brianjmurrell
approved these changes
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace installing daos-tests with daos-tests-internal for functional testing.
Signed-off-by: Phillip Henderson [email protected]