jgm/DAOS-16481: mercury: Added fixes and warning log entries for customer testing #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joseph Moore <[email protected]>
Signed-off-by: Joseph Moore <[email protected]>
Signed-off-by: Joseph Moore <[email protected]>
Signed-off-by: Joseph Moore <[email protected]>
Signed-off-by: Joseph Moore <[email protected]>
|
Just a head's up that this needs to have master merged to it. |
Signed-off-by: Joseph Moore <[email protected]>
frostedcmos
reviewed
Sep 4, 2024
mercury.spec
Outdated
| @@ -1,6 +1,6 @@ | |||
| Name: mercury | |||
| Version: 2.4.0~rc5 | |||
| Release: 1%{?dist} | |||
| Release: 2%{?dist} | |||
There was a problem hiding this comment.
this needs to be bumped to 3, as its 2 already in master.
frostedcmos
reviewed
Sep 4, 2024
debian/changelog
Outdated
| @@ -1,3 +1,9 @@ | |||
| mercury (2.4.0~rc5-2) unstable; urgency=medium | |||
There was a problem hiding this comment.
same here -- needs to be bumped to rc5-3; rc5-2 is already present in master
Signed-off-by: Joseph Moore <[email protected]>
Signed-off-by: Joseph Moore <[email protected]>
frostedcmos
reviewed
Sep 5, 2024
| + | ||
| NA_CHECK_SUBSYS_NA_ERROR( | ||
| addr, error, na_ret, "Could not insert new address"); | ||
|
|
There was a problem hiding this comment.
we should bump ref count by 1 here, to account for entry being used by new client. eventual disconnect for previous client will arrive, dropping the ref count. Without this, we end up deleting this newly created entry when previous clients disconnect even finally arrives.
(this should be only for the case when na_ucx_addr != NULL ) on line 33 above
Signed-off-by: Jerome Soumagne <[email protected]>
Signed-off-by: Joseph Moore <[email protected]>
Signed-off-by: Joseph Moore <[email protected]>
Signed-off-by: Joseph Moore <[email protected]>
Signed-off-by: Joseph Moore <[email protected]>
Signed-off-by: Joseph Moore <[email protected]>
Signed-off-by: Joseph Moore <[email protected]>
Signed-off-by: Joseph Moore <[email protected]>
Signed-off-by: Joseph Moore <[email protected]>
Signed-off-by: Joseph Moore <[email protected]>
Signed-off-by: Joseph Moore <[email protected]>
Signed-off-by: Joseph Moore <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.