Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16826 build: Fix compiling issues in gcc 14 (#15531) #15607

Draft
wants to merge 1 commit into
base: release/2.6
Choose a base branch
from
Draft

DAOS-16826 build: Fix compiling issues in gcc 14 (#15531) #15607

wants to merge 1 commit into from

Conversation

daltonbohning
Copy link
Contributor

  • Fix compiling issues in gcc 14

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@daltonbohning daltonbohning self-assigned this Dec 12, 2024
@daltonbohning daltonbohning added the release-2.6.3 Targeted for 2.6.3 label Dec 12, 2024
@daltonbohning daltonbohning added this to the Release 2.6.3 milestone Dec 12, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 12, 2024 •
edited
Loading

Ticket title is 'Fixed various compiling issue seen by latest gcc'
Status is 'Awaiting backport'
Labels: 'GCP'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-16826

@daltonbohning daltonbohning added the clean-cherry-pick Cherry-pick from another branch that did not require additional edits label Dec 12, 2024
@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15607/1/testReport/

This was referenced Dec 12, 2024
Merged
Merged
@jxiong @jolivier23 @daltonbohning
DAOS-16826 build: Fix compiling issues in gcc 14 (#15531)
7aac05a 
* Fix compiling issues in gcc 14

Signed-off-by: Jinshan Xiong <[email protected]>
Co-authored-by: Jeff Olivier <[email protected]>
Signed-off-by: Dalton Bohning <[email protected]>
@daltonbohning daltonbohning force-pushed the dbohning/daos-16826-2.6 branch from bcef513 to 7aac05a Compare December 14, 2024 14:40
@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label Dec 14, 2024
@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15607/2/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15607/2/execution/node/1465/log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@daltonbohning daltonbohning

Labels
clean-cherry-pick Cherry-pick from another branch that did not require additional edits priority Ticket has high priority (automatically managed) release-2.6.3 Targeted for 2.6.3
Milestone
Release 2.6.3
Development

Successfully merging this pull request may close these issues.
3 participants
@daltonbohning @daosbuild1 @jxiong