Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16833 cq: update GHA ubuntu #15538

Merged
merged 2 commits into from
Dec 5, 2024
Merged

DAOS-16833 cq: update GHA ubuntu #15538

merged 2 commits into from
Dec 5, 2024

Conversation

daltonbohning
Copy link
Contributor

Update mantic (EOL) to oracular.
Update 22.04 LTS to 24.04 LTS.

Skip-build: true

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@daltonbohning daltonbohning self-assigned this Nov 26, 2024
@github-actions GitHub Actions
Copy link

Ticket title is 'GHA: update ubuntu mantic to oracular'
Status is 'In Progress'
https://daosio.atlassian.net/browse/DAOS-16833

@daltonbohning daltonbohning force-pushed the dbohning/daos-16833 branch 2 times, most recently from 724a634 to 0c98f1d Compare November 26, 2024 21:31
@daltonbohning daltonbohning mentioned this pull request Dec 2, 2024
Merged
18 tasks
@daltonbohning daltonbohning force-pushed the dbohning/daos-16833 branch 2 times, most recently from bea9c97 to e758855 Compare December 4, 2024 15:56
@daltonbohning
DAOS-16833 cq: update GHA ubuntu
b681559 
Update mantic (EOL) to oracular.
Update 22.04 LTS to 24.04 LTS.

Test-tag: pr,vm,-daos_test

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
jolivier23
jolivier23 previously approved these changes Dec 4, 2024
View reviewed changes
@daltonbohning
fix opt
bd8c933 
Test-tag: pr,vm,-daos_test

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15538/10/execution/node/1211/log

@jolivier23 jolivier23 marked this pull request as ready for review December 5, 2024 15:43
@jolivier23 jolivier23 requested review from a team as code owners December 5, 2024 15:43
@jolivier23 jolivier23 merged commit c261a40 into master Dec 5, 2024
73 of 75 checks passed
@jolivier23 jolivier23 deleted the dbohning/daos-16833 branch December 5, 2024 15:43
daltonbohning added a commit that referenced this pull request Dec 5, 2024
@daltonbohning
DAOS-16833 cq: update GHA ubuntu (#15538)
6e04a4f 
Update mantic (EOL) to oracular.
Update 22.04 LTS to 24.04 LTS.

Test-tag: pr,vm,-daos_test

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
jolivier23 pushed a commit that referenced this pull request Dec 6, 2024
@daltonbohning @jolivier23
DAOS-16833 cq: update GHA ubuntu (#15538)
fad057f 
Update mantic (EOL) to oracular.
Update 22.04 LTS to 24.04 LTS.

Signed-off-by: Dalton Bohning <[email protected]>
jolivier23 pushed a commit that referenced this pull request Dec 6, 2024
@daltonbohning @jolivier23
DAOS-16833 cq: update GHA ubuntu (#15538)
b6327fa 
Update mantic (EOL) to oracular.
Update 22.04 LTS to 24.04 LTS.

Signed-off-by: Dalton Bohning <[email protected]>
jolivier23 pushed a commit that referenced this pull request Dec 8, 2024
@daltonbohning @jolivier23
DAOS-16833 cq: update GHA ubuntu (#15538)
83af413 
Update mantic (EOL) to oracular.
Update 22.04 LTS to 24.04 LTS.

Signed-off-by: Dalton Bohning <[email protected]>
daltonbohning added a commit that referenced this pull request Dec 12, 2024
@daltonbohning
DAOS-16833 cq: update GHA ubuntu (#15538)
2c87b1d 
Update mantic (EOL) to oracular.
Update 22.04 LTS to 24.04 LTS.

Test-tag: pr,vm,-daos_test

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
daltonbohning added a commit that referenced this pull request Dec 14, 2024
@daltonbohning
DAOS-16833 cq: update GHA ubuntu (#15538)
81cd901 
Update mantic (EOL) to oracular.
Update 22.04 LTS to 24.04 LTS.

Test-tag: pr,vm,-daos_test

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
daltonbohning added a commit that referenced this pull request Dec 16, 2024
@daltonbohning
DAOS-16833 cq: update GHA ubuntu (#15538)
073f375 
Update mantic (EOL) to oracular.
Update 22.04 LTS to 24.04 LTS.

Test-tag: pr,vm,-daos_test

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jolivier23 jolivier23 jolivier23 approved these changes

@mjmac mjmac mjmac approved these changes

Assignees

@daltonbohning daltonbohning

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daltonbohning @daosbuild1 @mjmac @jolivier23