Performance improvements to CoberturaParser #691
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CoberturaParser
rather than re-filtering the xml document all over the place.string.Concat
inProcessClass
method which were showing up in hot paths in profilingIn local testing, this reduces parsing time from roughly 11.5secs to 9 seconds, as well as reducing memory allocations from 17GB to 2.2GB.
For reference below is the code I tested with
And the following show the GCStats results from PerfView
Before
After