Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pkg_resources with importlib #462

Merged
merged 1 commit into from
May 25, 2023

Conversation

pi-slh
Copy link
Contributor

@pi-slh pi-slh commented Feb 22, 2023

  • Updates _version.py with importlib.metadata
  • Updates pyproject.toml with importlib-metadata for python 3.7

Addresses #461

* Updates _version.py with importlib.metadata
* Updates pyproject.toml with importlib-metadata for python 3.7
@nullswan
Copy link

Bump, pkg_resources is deprecated Python>=3.9 (Ref: https://setuptools.pypa.io/en/latest/pkg_resources.html)
image

Copy link
Collaborator

@Gobot1234 Gobot1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@Gobot1234 Gobot1234 merged commit aad7d2a into danielgtaylor:master May 25, 2023
@MicaelJarniac
Copy link
Contributor

When will this be included in a release or pre-release?

@Gobot1234
Copy link
Collaborator

I can't make any promises but I'm free most of next week so if any maintainers are free I'll be able to hopefully get out b6

bbonenfant pushed a commit to pachyderm/python-betterproto that referenced this pull request Jan 23, 2024
# Conflicts:
#	poetry.lock
#	pyproject.toml
bbonenfant added a commit to pachyderm/python-betterproto that referenced this pull request Jan 23, 2024
# Conflicts:
#	poetry.lock
#	pyproject.toml

# Conflicts:
#	poetry.lock
#	pyproject.toml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants