Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve node-pre-gyp support #13

Merged
merged 4 commits into from
Oct 18, 2022
Merged

Conversation

mmomtchev
Copy link
Contributor

  • allows searching for node-pre-gyp when it is not installed in the main package node_modules - often it will be in node_modules/native_module/node_modules
  • removes the node-pre-gyp require which pulls AWS S3 dependencies
  • actually documents this very useful feature that I found about only when I decided to implement it myself :-)

@mmomtchev
Copy link
Contributor Author

@danielgindi this PR fixes a certain number of native modules (including mine - gdal-async)

@danielgindi
Copy link
Owner

@danielgindi this PR fixes a certain number of native modules (including mine - gdal-async)

I have reviewed your PR a long time ago, but you have not responded to any of the comments

@mmomtchev
Copy link
Contributor Author

Sorry, but I don't see any comments?

@danielgindi
Copy link
Owner

danielgindi commented Oct 12, 2022

Sorry, but I don't see any comments?

Sorry, the review was not submitted. Ufff.

src/index.js Show resolved Hide resolved
src/index.js Outdated Show resolved Hide resolved
@danielgindi
Copy link
Owner

@mmomtchev
I want to merge this. I'd love it if you put some comments to highlight the different situations you encountered, at the points where the code handles them. We don't want to break anything later.

@mmomtchev
Copy link
Contributor Author

@danielgindi I commented the two changes

@mmomtchev
Copy link
Contributor Author

I have been using this in a closed source project for about an year, but now I use it in an open-source project, you can see it here: https://github.com/mmomtchev/xc-db

I am using rollup to bundle my Node.js back-end server so that I do not have to handle node_modules in a production environment. The native module I am using is gdal-async of which I am also the maintainer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants