-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve node-pre-gyp support #13
Conversation
mmomtchev
commented
Sep 4, 2021
- allows searching for node-pre-gyp when it is not installed in the main package node_modules - often it will be in node_modules/native_module/node_modules
- removes the node-pre-gyp require which pulls AWS S3 dependencies
- actually documents this very useful feature that I found about only when I decided to implement it myself :-)
@danielgindi this PR fixes a certain number of native modules (including mine - |
I have reviewed your PR a long time ago, but you have not responded to any of the comments |
Sorry, but I don't see any comments? |
Sorry, the review was not submitted. Ufff. |
@mmomtchev |
@danielgindi I commented the two changes |
I have been using this in a closed source project for about an year, but now I use it in an open-source project, you can see it here: https://github.com/mmomtchev/xc-db I am using rollup to bundle my Node.js back-end server so that I do not have to handle |