Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert patch to edit org info #155

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

stefan0xC
Copy link
Contributor

Sorry, another issue introduced by me. 🫣

fixes this external bug report

@BlackDex
Copy link
Collaborator

BlackDex commented Feb 4, 2024

Luckily we didn't released 1.30.4 yet 😂

@stefan0xC
Copy link
Contributor Author

stefan0xC commented Feb 4, 2024

I think I'll have to get more familiar with the web-vault because the whole isSelfHosted stuff is very confusing to me. (Sometimes we want it to be true other times false and even though we self host Vaultwarden, we decided to set it to false by default.) 😅

@BlackDex
Copy link
Collaborator

BlackDex commented Feb 4, 2024

That is more because of the whole organization licensing part.
The non-self-hosted allows to create orgs without a license file, the self-hosted need a file.

So, we mimic a bit more the SaaS version of the web-vault this way.

@stefan0xC
Copy link
Contributor Author

Yeah, but I think it would be less confusing (at least to me) if it would default to true and we only made the necessary changes wherever we had to instead of pretending to be the cloud version and having to decide where it's necessary to revert the check for self hosted. 🤔

@BlackDex
Copy link
Collaborator

BlackDex commented Feb 4, 2024

Worth looking into i think.

patches/v2024.1.2.patch Show resolved Hide resolved
@stefan0xC
Copy link
Contributor Author

stefan0xC commented Feb 6, 2024

I'll do a separate PR once this is merged for rewriting the patch file, because I'd be using the opportunity to also change the background color of the navbar to the color we use in the /admin navbar, i.e. #212529 (which should be discussed separately I think). Because a self hosted Bitwarden instance uses a different background color (#1a3b66) from the default #175ddc.

@BlackDex BlackDex merged commit 4430ef7 into dani-garcia:master Feb 7, 2024
@stefan0xC stefan0xC deleted the fix-org-renaming branch February 7, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants