Vote on prefix-only core modules (nodejs#1206)

* Vote on `node:`-only core modules * vote from aduh95 * vote from cjihrig * vote from mhdawson * vote from apapirovski * vote from Rich Trott * vote from fhinkel * vote from RaisinTen * vote from targos * vote from gireeshpunathil * vote from Matteo Collina * vote from Richard Lau * vote from Beth Griggs * vote from gireeshpunathil * vote from Danielle Adams * Vote for test runner node prefix * vote from MylesBorins * close vote and aggregate results * add vote from joyeecheung Co-authored-by: Joyee Cheung <[email protected]> * close vote and aggregate results Co-authored-by: cjihrig <[email protected]> Co-authored-by: Michael Dawson <[email protected]> Co-authored-by: Anatoli Papirovski <[email protected]> Co-authored-by: Rich Trott <[email protected]> Co-authored-by: Franziska Hinkelmann <[email protected]> Co-authored-by: Darshan Sen <[email protected]> Co-authored-by: Michaël Zasso <[email protected]> Co-authored-by: Gireesh Punathil <[email protected]> Co-authored-by: Matteo Collina <[email protected]> Co-authored-by: Richard Lau <[email protected]> Co-authored-by: Beth Griggs <[email protected]> Co-authored-by: Danielle Adams <[email protected]> Co-authored-by: James M Snell <[email protected]> Co-authored-by: Myles Borins <[email protected]> Co-authored-by: Joyee Cheung <[email protected]>
danbev · Apr 14, 2022 · 8fcbb34 · 8fcbb34
1 parent 4e5f211
commit 8fcbb34
Show file tree

Hide file tree

Showing 2 changed files with 180 additions and 0 deletions.
diff --git a/votes/2022-04-11-0.json b/votes/2022-04-11-0.json
@@ -0,0 +1,155 @@
+{
+  "description": "`node:`-only core modules and built-in test runner module",
+  "outcome": {
+    "winner(s)": [
+      "Ship the test runner as `node:test` and `require('test')` loads from userland."
+    ]
+  },
+  "votes": {
+    "joyeecheung": {
+      "Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module).": 0,
+      "Ship the test runner as `test` (also available as `node:test`, like other current core modules).": 0,
+      "Ship the test runner as `node:test` and `require('test')` loads from userland.": 2,
+      "Ship the test runner as `node:test` and `require('test')` throws.": 1,
+      "Ship the test runner as `test_runner` (also available as `node:test_runner`, like other current core modules).": 0,
+      "Ship the test runner as `node:test_runner` and `require('test_runner')` loads from userland.": 0,
+      "Ship the test runner as `node:test_runner` and `require('test_runner')` throws.": 0
+    },
+    "MylesBorins": {
+      "Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module).": 0,
+      "Ship the test runner as `test` (also available as `node:test`, like other current core modules).": 0,
+      "Ship the test runner as `node:test` and `require('test')` loads from userland.": 0,
+      "Ship the test runner as `node:test` and `require('test')` throws.": 0,
+      "Ship the test runner as `test_runner` (also available as `node:test_runner`, like other current core modules).": 0,
+      "Ship the test runner as `node:test_runner` and `require('test_runner')` loads from userland.": 0,
+      "Ship the test runner as `node:test_runner` and `require('test_runner')` throws.": 0
+    },
+    "danielleadams": {
+      "Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module).": -1,
+      "Ship the test runner as `test` (also available as `node:test`, like other current core modules).": 0,
+      "Ship the test runner as `node:test` and `require('test')` loads from userland.": 0,
+      "Ship the test runner as `node:test` and `require('test')` throws.": 2,
+      "Ship the test runner as `test_runner` (also available as `node:test_runner`, like other current core modules).": 2,
+      "Ship the test runner as `node:test_runner` and `require('test_runner')` loads from userland.": 0,
+      "Ship the test runner as `node:test_runner` and `require('test_runner')` throws.": 3
+    },
+    "gireeshpunathil": {
+      "Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module).": 1,
+      "Ship the test runner as `test` (also available as `node:test`, like other current core modules).": 0,
+      "Ship the test runner as `node:test` and `require('test')` loads from userland.": 0,
+      "Ship the test runner as `node:test` and `require('test')` throws.": 0,
+      "Ship the test runner as `test_runner` (also available as `node:test_runner`, like other current core modules).": 0,
+      "Ship the test runner as `node:test_runner` and `require('test_runner')` loads from userland.": 0,
+      "Ship the test runner as `node:test_runner` and `require('test_runner')` throws.": 0
+    },
+    "jasnell": {
+      "Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module).": 1,
+      "Ship the test runner as `test` (also available as `node:test`, like other current core modules).": -1,
+      "Ship the test runner as `node:test` and `require('test')` loads from userland.": -1,
+      "Ship the test runner as `node:test` and `require('test')` throws.": 0,
+      "Ship the test runner as `test_runner` (also available as `node:test_runner`, like other current core modules).": 1,
+      "Ship the test runner as `node:test_runner` and `require('test_runner')` loads from userland.": -1,
+      "Ship the test runner as `node:test_runner` and `require('test_runner')` throws.": 0
+    },
+    "mcollina": {
+      "Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module).": -100,
+      "Ship the test runner as `test` (also available as `node:test`, like other current core modules).": -90,
+      "Ship the test runner as `node:test` and `require('test')` loads from userland.": 100,
+      "Ship the test runner as `node:test` and `require('test')` throws.": -80,
+      "Ship the test runner as `test_runner` (also available as `node:test_runner`, like other current core modules).": 0,
+      "Ship the test runner as `node:test_runner` and `require('test_runner')` loads from userland.": -10,
+      "Ship the test runner as `node:test_runner` and `require('test_runner')` throws.": -10
+    },
+    "BethGriggs": {
+      "Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module).": 0,
+      "Ship the test runner as `test` (also available as `node:test`, like other current core modules).": 4,
+      "Ship the test runner as `node:test` and `require('test')` loads from userland.": 5,
+      "Ship the test runner as `node:test` and `require('test')` throws.": 3,
+      "Ship the test runner as `test_runner` (also available as `node:test_runner`, like other current core modules).": 1,
+      "Ship the test runner as `node:test_runner` and `require('test_runner')` loads from userland.": 0,
+      "Ship the test runner as `node:test_runner` and `require('test_runner')` throws.": 0
+    },
+    "richardlau": {
+      "Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module).": -1,
+      "Ship the test runner as `test` (also available as `node:test`, like other current core modules).": 1,
+      "Ship the test runner as `node:test` and `require('test')` loads from userland.": 5,
+      "Ship the test runner as `node:test` and `require('test')` throws.": 5,
+      "Ship the test runner as `test_runner` (also available as `node:test_runner`, like other current core modules).": 10,
+      "Ship the test runner as `node:test_runner` and `require('test_runner')` loads from userland.": 4,
+      "Ship the test runner as `node:test_runner` and `require('test_runner')` throws.": 7
+    },
+    "fhinkel": {
+      "Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module).": 0,
+      "Ship the test runner as `test` (also available as `node:test`, like other current core modules).": 0,
+      "Ship the test runner as `node:test` and `require('test')` loads from userland.": 0,
+      "Ship the test runner as `node:test` and `require('test')` throws.": 0,
+      "Ship the test runner as `test_runner` (also available as `node:test_runner`, like other current core modules).": 0,
+      "Ship the test runner as `node:test_runner` and `require('test_runner')` loads from userland.": 0,
+      "Ship the test runner as `node:test_runner` and `require('test_runner')` throws.": 0
+    },
+    "targos": {
+      "Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module).": 0,
+      "Ship the test runner as `test` (also available as `node:test`, like other current core modules).": 3,
+      "Ship the test runner as `node:test` and `require('test')` loads from userland.": 1,
+      "Ship the test runner as `node:test` and `require('test')` throws.": 2,
+      "Ship the test runner as `test_runner` (also available as `node:test_runner`, like other current core modules).": 3,
+      "Ship the test runner as `node:test_runner` and `require('test_runner')` loads from userland.": 0,
+      "Ship the test runner as `node:test_runner` and `require('test_runner')` throws.": 1
+    },
+    "RaisinTen": {
+      "Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module).": 6,
+      "Ship the test runner as `test` (also available as `node:test`, like other current core modules).": 4,
+      "Ship the test runner as `node:test` and `require('test')` loads from userland.": 7,
+      "Ship the test runner as `node:test` and `require('test')` throws.": 3,
+      "Ship the test runner as `test_runner` (also available as `node:test_runner`, like other current core modules).": 5,
+      "Ship the test runner as `node:test_runner` and `require('test_runner')` loads from userland.": 2,
+      "Ship the test runner as `node:test_runner` and `require('test_runner')` throws.": 1
+    },
+    "Trott": {
+      "Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module).": 0,
+      "Ship the test runner as `test` (also available as `node:test`, like other current core modules).": 0,
+      "Ship the test runner as `node:test` and `require('test')` loads from userland.": 1,
+      "Ship the test runner as `node:test` and `require('test')` throws.": 0,
+      "Ship the test runner as `test_runner` (also available as `node:test_runner`, like other current core modules).": 1,
+      "Ship the test runner as `node:test_runner` and `require('test_runner')` loads from userland.": 1,
+      "Ship the test runner as `node:test_runner` and `require('test_runner')` throws.": 1
+    },
+    "apapirovski": {
+      "Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module).": 0,
+      "Ship the test runner as `test` (also available as `node:test`, like other current core modules).": 1,
+      "Ship the test runner as `node:test` and `require('test')` loads from userland.": 5,
+      "Ship the test runner as `node:test` and `require('test')` throws.": 3,
+      "Ship the test runner as `test_runner` (also available as `node:test_runner`, like other current core modules).": 2,
+      "Ship the test runner as `node:test_runner` and `require('test_runner')` loads from userland.": 6,
+      "Ship the test runner as `node:test_runner` and `require('test_runner')` throws.": 4
+    },
+    "cjihrig": {
+      "Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module).": -100000,
+      "Ship the test runner as `test` (also available as `node:test`, like other current core modules).": -5,
+      "Ship the test runner as `node:test` and `require('test')` loads from userland.": 1,
+      "Ship the test runner as `node:test` and `require('test')` throws.": -1,
+      "Ship the test runner as `test_runner` (also available as `node:test_runner`, like other current core modules).": 1000000,
+      "Ship the test runner as `node:test_runner` and `require('test_runner')` loads from userland.": -50,
+      "Ship the test runner as `node:test_runner` and `require('test_runner')` throws.": -100
+    },
+    "mhdawson": {
+      "Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module).": 1,
+      "Ship the test runner as `test` (also available as `node:test`, like other current core modules).": 2,
+      "Ship the test runner as `node:test` and `require('test')` loads from userland.": 7,
+      "Ship the test runner as `node:test` and `require('test')` throws.": 5,
+      "Ship the test runner as `test_runner` (also available as `node:test_runner`, like other current core modules).": 3,
+      "Ship the test runner as `node:test_runner` and `require('test_runner')` loads from userland.": 6,
+      "Ship the test runner as `node:test_runner` and `require('test_runner')` throws.": 4
+    },
+    "aduh95": {
+      "Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module).": 0,
+      "Ship the test runner as `test` (also available as `node:test`, like other current core modules).": 0,
+      "Ship the test runner as `node:test` and `require('test')` loads from userland.": 0,
+      "Ship the test runner as `node:test` and `require('test')` throws.": 0,
+      "Ship the test runner as `test_runner` (also available as `node:test_runner`, like other current core modules).": 0,
+      "Ship the test runner as `node:test_runner` and `require('test_runner')` loads from userland.": 0,
+      "Ship the test runner as `node:test_runner` and `require('test_runner')` throws.": 0
+    }
+  },
+  "refs": ["https://github.com/nodejs/TSC/pull/1206"]
+}
diff --git a/votes/2022-04-11-1.json b/votes/2022-04-11-1.json
@@ -0,0 +1,25 @@
+{
+  "description": "Ship the test runner as node:test and require('test') loads from userland.",
+  "refs": ["https://github.com/nodejs/TSC/pull/1206#issuecomment-1096855085"],
+  "outcome": "Yes",
+  "votes": {
+    "aduh95": 1,
+    "richardlau": 1,
+    "RaisinTen": 1,
+    "apapirovski": 1,
+    "mhdawson": 1,
+    "BethGriggs": 1,
+    "joyeecheung": 1,
+    "mcollina": 1,
+    "ChALkeR": 1,
+    "cjihrig": -1,
+    "jasnell": -1,
+    "Trott": 0,
+    "targos": 0,
+    "gireeshpunathil": 0,
+    "fhinkel": 0,
+    "tniessen": 0,
+    "BridgeAR": 0,
+    "MylesBorins": 0
+  }
+}