Parse non-english tasklist, force kill #11
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a non-english Windows, the csv output of
tasklist /FO CSV
has non-english headers. As reported at #10, running this:Results in entries like:
I.e., the
PID
key that dalek-browser-ie expects, is in Dutch (Proces-id
). Because of this underlying bug, IE will not be closed after running tests. This PR fixes that by assuming that the second CSV column is the PID. I'm not sure if the column order can be guaranteed. To be safe, the script tests if the PID is an integer.Additionally, I've found that a forced kill is required more often than not.
I'm on Win7 64bit, using IE 11.0.9600.17105, Dalek CLI 0.0.4, Dalek local 0.0.8.