Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse non-english tasklist, force kill #11

Merged
merged 2 commits into from
Jun 28, 2014
Merged

Conversation

vweevers
Copy link
Contributor

On a non-english Windows, the csv output of tasklist /FO CSV has non-english headers. As reported at #10, running this:

var ie = require('dalek-browser-ie');
ie._list(console.log.bind(console));

Results in entries like:

{ Imagenaam: 'chrome.exe',
  'Proces-id': '8184',
  Sessienaam: 'Console',
  'Sessienr.': '1',
  Geheugengebruik: '22.196 kB' }

I.e., the PID key that dalek-browser-ie expects, is in Dutch (Proces-id). Because of this underlying bug, IE will not be closed after running tests. This PR fixes that by assuming that the second CSV column is the PID. I'm not sure if the column order can be guaranteed. To be safe, the script tests if the PID is an integer.

Additionally, I've found that a forced kill is required more often than not.

I'm on Win7 64bit, using IE 11.0.9600.17105, Dalek CLI 0.0.4, Dalek local 0.0.8.

@asciidisco
Copy link
Member

I was fiddling around with this issue for ages now (also because it is hard to reproduce & test, because in the english and german version of Windows it is named PID)

I can not say how thankful I am for that PR 👍

asciidisco added a commit that referenced this pull request Jun 28, 2014
fix(core): Parse non-english tasklist, force kill
@asciidisco asciidisco merged commit 4485418 into dalekjs:master Jun 28, 2014
@vweevers
Copy link
Contributor Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants