[dagster-azure] explicitly support access key and sas token in compute log manager #26653
+24
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
dpeng817
changed the title
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Adds back support of asset keys and sas tokens to the azure compute log manager under a new configurable parameter;
access_key_or_sas_token. I'm torn on whether these should be two separate variables, but since they're handled identically it seems reasonable to have them live in the same field. Downside is ugly name.We should also add back support for credential under the old name and issue a deprecation warning.
How I Tested These Changes
Added a new parametrization of the compute log manager integration test suite. Currently failing in bk because credentials need to be rotated, but passes local for me with a real access key.
Changelog
[dagster-azure] A new
access_key_or_sas_tokenparameter to theAzureBlobComputeLogManager, which allows you to authenticate via either access key or sas token.