[dagster-k8s] infer image from dagster/image tag in PipesK8sClient #26629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
gibsondan
approved these changes
Dec 20, 2024
Comment on lines
+429
to
+430
| if not base_pod_spec or len(base_pod_spec.get("containers", [])) == 1: | ||
| image = image or context.dagster_run.tags.get(DOCKER_IMAGE_TAG) |
There was a problem hiding this comment.
I think you could also fetch this using the same logic the run launcher does, but the run launcher does also set this tag, so I suppose either works.
There was a problem hiding this comment.
Do you want to assert in some fashion that it is non-null after doing this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
This should improve K8s Pipes UX in the obvious case of running only one container with no image provided from the user.
How I Tested These Changes
Existing tests
Changelog
[dagster-k8s]
PipesK8sClientnow defaults to using the image fromdagster/imageRun tag when running one container in the pod.