Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Add Google Drive icon for asset kinds tag #26349

Merged

Conversation

dragos-pop
Copy link
Contributor

Summary & Motivation

Add Google Drive icon (24x24 px; 1,100 bytes) for asset kinds tag.

I often read files from Google Drive using the google-api-python-client and having a dedicated icon instead of the generic Google icon would enhance the UI experience.

How I Tested These Changes

Launched the documentation website locally and verified that the kind was visible in the Supported Icons section (as in the screenshot below).

Screenshot 2024-12-09 at 15 03 47

Changelog

[ui] Add Google Drive icon for kind tags

@dragos-pop dragos-pop requested a review from neverett as a code owner December 9, 2024 14:12
Copy link
Contributor

@salazarm salazarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

@dragos-pop
Copy link
Contributor Author

Thanks @salazarm
I've addressed your comment!

@dragos-pop dragos-pop requested a review from salazarm December 16, 2024 18:25
@salazarm salazarm merged commit 1319682 into dagster-io:master Dec 16, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants