Add python 3.12 testing to buildkite #19588
Conversation
gibsondan
force-pushed
the
python312
branch
26 times, most recently
from
15fda99 to
41dfa4a
Compare
gibsondan
force-pushed
the
python312
branch
2 times, most recently
from
a3a5b2e to
11f07b6
Compare
|
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-k12lpj0p0-elementl.vercel.app Direct link to changed pages: |
gibsondan
changed the title
| # https://github.com/great-expectations/great_expectations/issues/7990 | ||
| "typing_extensions<4.6.0", |
There was a problem hiding this comment.
linked issue is resolved and was failing tests
| @@ -152,7 +152,7 @@ def test_successful_host_dagster_ui_from_workspace(): | |||
| log_level="warning", | |||
| ) | |||
|
|
|||
| assert server_call.called_with(mock.ANY, host="127.0.0.1", port=2343, log_level="warning") | |||
| server_call.assert_called_with(mock.ANY, host="127.0.0.1", port=2343, log_level="warning") | |||
There was a problem hiding this comment.
this was fun, CPython in 3.12 got smart enough to realize that this was just asserting that a Mock object was not None (always true), instead of the intended behavior
|
|
||
| if sys.version_info >= (3, 12): | ||
| # pendulum sometimes raises DeprecationWarning on python3.12 | ||
| warnings.filterwarnings("ignore", category=DeprecationWarning, module="pendulum") |
There was a problem hiding this comment.
unrelated pendulum DeprecationWarnings were failing tests that tried to suppress dagster ExperimentalWarnings
|
|
||
| from dagster_tests.cli_tests.command_tests.test_cli_commands import ( |
There was a problem hiding this comment.
this (and a couple of other similar fixes below) are no longer needed anymore now that we are installing in legacy editable mode, but can't hurt to keep either
|
#19780 adds the setup.py markers |
gibsondan
force-pushed
the
python312
branch
7 times, most recently
from
8e05997 to
3e4fb08
Compare
[test-all]
## Summary & Motivation Leaving the default at 3.11 since not all packages are supported yet, but with the release of universal_pathlib 0.2 today we are ready to support 3.12 in many of the core packages. The only changes that were required here were in tests. resolves #17350 Test Plan: BK
Summary & Motivation
Leaving the default at 3.11 since not all packages are supported yet, but with the release of universal_pathlib 0.2 today we are ready to support 3.12 in many of the core packages. The only changes that were required here were in tests.
resolves #17350
Test Plan: BK