Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix position of link input in rich editor #760

Merged
merged 1 commit into from
Jul 25, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions app/components/RichEditor/RichEditor.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,12 @@ export default class RichEditor extends React.Component {
}
}

componentDidUpdate(_, prevState) {
if (this.state.isFullscreen !== prevState.isFullscreen) {
this.containerBounds = this.container.getBoundingClientRect()
}
}

componentWillMount() {
this.hotKeys.removeListener()
}
Expand Down Expand Up @@ -500,10 +506,7 @@ export default class RichEditor extends React.Component {
const valueIsLink = this.hasInline(NODE_LINK)

return (
<div
className={containerStyle.getClasses()}
ref={el => (this.container = el)}
>
<div className={containerStyle.getClasses()}>
{isSelectingMedia && (
<Modal
onRequestClose={this.handleToggleMediaSelect.bind(this, false)}
Expand Down Expand Up @@ -605,7 +608,10 @@ export default class RichEditor extends React.Component {
</div>
</RichEditorToolbar>

<div className={editorWrapperStyle.getClasses()}>
<div
className={editorWrapperStyle.getClasses()}
ref={el => (this.container = el)}
>
<Editor
className={styles.editor}
onChange={this.handleChange.bind(this)}
Expand Down
3 changes: 0 additions & 3 deletions app/components/RichEditor/RichEditorLink.css
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,8 @@ input:focus {
.popup {
background-color: black;
border-radius: 4px;
bottom: 100%;
box-shadow: 7px 6px 25px rgba(0, 0, 0, 0.3);
color: white;
left: 0;
margin: 6px 0 10px 0;
padding: 5px 10px;
position: absolute;
z-index: 10;
Expand Down
41 changes: 23 additions & 18 deletions app/components/RichEditor/RichEditorLink.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,13 @@ export default class RichEditorLink extends React.Component {
this.state = {
editing: props.href === '',
href: props.href,
offsetRight: 0
popupStyle: {}
}
}

componentDidMount() {
document.body.addEventListener('mousedown', this.clickHandler)
this.offsetPopup()
}

componentWillUnmount() {
Expand Down Expand Up @@ -80,25 +81,24 @@ export default class RichEditorLink extends React.Component {
})
}

handlePopupRef(element) {
offsetPopup() {
const {bounds} = this.props
const {popupElement, container} = this

if (!bounds || !element || this.hasAdjustedPosition) {
if (!bounds || !popupElement || !container) {
return
}

const {right, top} = element.getBoundingClientRect()
const offsetRight = right - bounds.right
const offsetTop = top - bounds.top - element.clientHeight * 2.5
const {right} = popupElement.getBoundingClientRect()
const {top: linkTop} = this.container.getBoundingClientRect()

this.hasAdjustedPosition = true
const leftOffset = Math.min(bounds.right - right, 0)
const verticalOffset = -popupElement.clientHeight * 1.5
const topOrBottom = bounds.top > linkTop + verticalOffset ? 'bottom' : 'top'

if (offsetRight > 0 || offsetTop < 0) {
this.setState({
offsetRight: Math.max(offsetRight, 0),
offsetTop: Math.abs(Math.min(offsetTop, 0))
})
}
this.setState({
popupStyle: {left: leftOffset, [topOrBottom]: verticalOffset}
})
}

handleSave(event) {
Expand All @@ -118,10 +118,15 @@ export default class RichEditorLink extends React.Component {

render() {
const {children} = this.props
const {editing, href, offsetRight, offsetTop} = this.state
const {editing, href, popupStyle} = this.state

return (
<span className={styles.container} ref={el => (this.container = el)}>
<span
className={styles.container}
ref={el => {
this.container = el
}}
>
<a href={href} onClick={this.handleLinkClick.bind(this)}>
{children}
</a>
Expand All @@ -130,10 +135,10 @@ export default class RichEditorLink extends React.Component {
<div
className={styles.popup}
contentEditable={false}
ref={this.handlePopupRef.bind(this)}
style={{
transform: `translate3d(-${offsetRight}px, ${offsetTop}px, 0)`
ref={el => {
this.popupElement = el
}}
style={popupStyle}
>
<form className={styles.form} onSubmit={this.handleSave.bind(this)}>
<input
Expand Down