chore: Cleanup duplication across tsconfig files in packages (#30764)

* Cleanup duplication across tsconfig files in packages * empty commit * Add ts-ignore * Add ts-ignore
cypress-io · Dec 16, 2024 · 68c5714 · 68c5714 · cypress-bot · Dec 16, 2024
1 parent 53d47cf
commit 68c5714
Show file tree

Hide file tree

Showing 20 changed files with 115 additions and 210 deletions.
diff --git a/packages/app/tsconfig.json b/packages/app/tsconfig.json
@@ -13,15 +13,13 @@
   ],
   "compilerOptions": {
     "noImplicitThis": true,
-    "useDefineForClassFields": true,
     "paths": {
       "@cy/i18n": ["../frontend-shared/src/locales/i18n"],
       "@cy/components/*": ["../frontend-shared/src/components/*"],
       "@cy/gql-components/*": ["../frontend-shared/src/gql-components/*"],
       "@cy/store/*": ["../frontend-shared/src/store/*"],
       "@packages/*": ["../*"]
     },
-    "allowJs": true,
     "types": [
       "cypress", 
       "cypress-real-events", 

diff --git a/packages/config/tsconfig.json b/packages/config/tsconfig.json
@@ -7,19 +7,9 @@
     "test"
   ],
   "compilerOptions": {
-    "strict": true,
     "allowJs": false,
     "rootDir": "src",
     "noImplicitAny": true,
-    "resolveJsonModule": true,
-    "experimentalDecorators": true,
-    "noUncheckedIndexedAccess": true,
-    "ignoreDeprecations": "5.0",
-    /* 
-     * TODO: remove importsNotUsedAsValues after typescript 5.5 and up as it will no longer work. If we want the same behavior
-     * as importsNotUsedAsValues, we need to use "verbatimModuleSyntax", which will require this package to be an ES Module.
-     */
-    "importsNotUsedAsValues": "error",
     "types": ["node"],
     "typeRoots": [
       "../../node_modules/@types"

diff --git a/packages/data-context/tsconfig.json b/packages/data-context/tsconfig.json
@@ -9,19 +9,8 @@
   ],
   "compilerOptions": {
     "lib": ["esnext"],
-    "strict": true,
     "allowJs": false,
     "noImplicitAny": true,
-    "resolveJsonModule": true,
-    "experimentalDecorators": true,
-    "noUnusedLocals": false,
-    "noUncheckedIndexedAccess": true,
-    "ignoreDeprecations": "5.0",
-    /* 
-     * TODO: remove importsNotUsedAsValues after typescript 5.5 and up as it will no longer work. If we want the same behavior
-     * as importsNotUsedAsValues, we need to use "verbatimModuleSyntax", which will require this package to be an ES Module.
-     */
-    "importsNotUsedAsValues": "error",
     "types": ["cypress"],
   }
 }
diff --git a/packages/driver/tsconfig.json b/packages/driver/tsconfig.json
@@ -3,23 +3,15 @@
   "compilerOptions": {
     "target": "ES2016",
     "lib": ["ES2021", "DOM", "DOM.Iterable"],
-    "module": "commonjs",
     "allowJs": true,
-    "noImplicitAny": false,
     "noImplicitThis": false,
     "strictFunctionTypes": true,
     "preserveWatchOutput": true,
     "sourceMap": true,
-    "importHelpers": true,
     "strictNullChecks": true,
-    "strict": true,
     "forceConsistentCasingInFileNames": true,
-    "skipLibCheck": true,
     "noEmit": true,
-    "noImplicitReturns": true,
-    "allowSyntheticDefaultImports": true,
     "outDir": "dist",
-    "esModuleInterop": true,
     "noErrorTruncation": true,
     "types": []
   },

diff --git a/packages/errors/tsconfig.json b/packages/errors/tsconfig.json
@@ -4,18 +4,8 @@
     "src",
   ],
   "compilerOptions": {
-    "strict": true,
     "allowJs": false,
     "noImplicitAny": true,
-    "resolveJsonModule": true,
-    "experimentalDecorators": true,
     "noImplicitReturns": false,
-    "noUncheckedIndexedAccess": true,
-    "ignoreDeprecations": "5.0",
-    /* 
-     * TODO: remove importsNotUsedAsValues after typescript 5.5 and up as it will no longer work. If we want the same behavior
-     * as importsNotUsedAsValues, we need to use "verbatimModuleSyntax", which will require this package to be an ES Module.
-     */
-    "importsNotUsedAsValues": "error",
   }
 }
diff --git a/packages/extension/tsconfig.json b/packages/extension/tsconfig.json
@@ -1,12 +1,7 @@
 {
+  "extends": "../ts/tsconfig.json",
   "compilerOptions": {
     "target": "es2015",
-    "module": "commonjs",
-    "allowJs": true,
-    "allowSyntheticDefaultImports": true,
-    "esModuleInterop": true,
-    "noImplicitAny": false,
-    "importHelpers": true,
     "strict": false
   }
 }
diff --git a/packages/frontend-shared/tsconfig.json b/packages/frontend-shared/tsconfig.json
@@ -1,55 +1,12 @@
 {
+  "extends": "../ts/tsconfig.json",
   "compilerOptions": {
-    /* Basic Options */
-    "target": "ES2018",
     "module": "esnext",
     "lib": ["dom", "ESNext"],
-    /*
-     * Allow javascript files to be compiled.
-     * Override this in modules that need JS
-     */
-    "noEmit": true,
     "jsx": "preserve",
     "preserveWatchOutput": true,
-    // "checkJs": true,                       /* Report errors in .js files. */
-    // "jsx": "preserve",                     /* Specify JSX code generation: 'preserve', 'react-native', or 'react'. */
-    /* Generates corresponding '.d.ts' file. */
-    // "declaration": true,
-    // "declarationMap": true,                /* Generates a sourcemap for each corresponding '.d.ts' file. */
-    /* Generates corresponding '.map' file. */
-    "sourceMap": true,
-    /* Import emit helpers from 'tslib'. */
-    "importHelpers": true,
-    "strictNullChecks": true,
-    // "downlevelIteration": true,            /* Provide full support for iterables in 'for-of', spread, and destructuring when targeting 'ES5' or 'ES3'. */
-    // "isolatedModules": true,               /* Transpile each file as a separate module (similar to 'ts.transpileModule'). */
-    /* Strict Type-Checking Options */
-    // "traceResolution": true,
-    "strict": true,
-    "noImplicitAny": false,
     "noImplicitThis": false,
-    "forceConsistentCasingInFileNames": true,
-    /**
-     * Skip type checking of all declaration files (*.d.ts).
-     * TODO: Look into changing this in the future
-     */
-    /* Additional Checks */
-    "skipLibCheck": true,
-    /* Report errors on unused locals. */
-    // "noEmit": true,
-    "noUnusedLocals": false,
-    // "noUnusedParameters": true,            /* Report errors on unused parameters. */
-    /* Report error when not all code paths in function return a value. */
-    "noImplicitReturns": true,
-    // "noFallthroughCasesInSwitch": true,    /* Report errors for fallthrough cases in switch statement. */
-    /* Module Resolution Options */
-    "moduleResolution": "node",            /* Specify module resolution strategy: 'node' (Node.js) or 'classic' (TypeScript pre-1.6). */
-    // "baseUrl": "./",                       /* Base directory to resolve non-absolute module names. */
-    // "paths": {},                           /* A series of entries which re-map imports to lookup locations relative to the 'baseUrl'. */
-    // "rootDirs": ["../driver/src"],                        /* List of root folders whose combined content represents the structure of the project at runtime. */
-    // "typeRoots": [] /* List of folders to include type definitions from. */
-
-    /* Type declaration files to be included in compilation. */
+    "noErrorTruncation": true,
     "paths": {
       "@cy/i18n": ["../frontend-shared/src/locales/i18n"],
       "@cy/components/*": ["../frontend-shared/src/components/*"]
@@ -63,17 +20,5 @@
       "cypress-real-events", 
       "cypress"
     ],
-    "allowSyntheticDefaultImports": true,
-    "esModuleInterop": true,
-    "noErrorTruncation": true,
-    "experimentalDecorators": true,
-    "resolveJsonModule": true,
-    "ignoreDeprecations": "5.0",
-    /* 
-     * TODO: remove importsNotUsedAsValues after typescript 5.5 and up as it will no longer work. If we want the same behavior
-     * as importsNotUsedAsValues, we need to use "verbatimModuleSyntax", which will require this package to be an ES Module.
-     */
-    "importsNotUsedAsValues": "error",
-    "useUnknownInCatchVariables": false
   }
 }
diff --git a/packages/graphql/src/utils/nexusTypegenUtils.ts b/packages/graphql/src/utils/nexusTypegenUtils.ts
@@ -92,7 +92,6 @@ const nexusTypegenDebounced = (cfg: NexusTypegenCfg) => {
   debounced[cfg.filePath] =
     debounced[cfg.filePath] ?? _.debounce(nexusTypegen, 500)
 
-  // @ts-expect-error
   debounced[cfg.filePath](cfg)
 }
 

diff --git a/packages/graphql/tsconfig.json b/packages/graphql/tsconfig.json
@@ -10,19 +10,8 @@
   ],
   "compilerOptions": {
     "lib": ["esnext"],
-    "strict": true,
     "allowJs": false,
     "noImplicitAny": true,
-    "noUnusedLocals": false,
-    "resolveJsonModule": true,
-    "experimentalDecorators": true,
-    "noUncheckedIndexedAccess": true,
-    "ignoreDeprecations": "5.0",
-    /* 
-     * TODO: remove importsNotUsedAsValues after typescript 5.5 and up as it will no longer work. If we want the same behavior
-     * as importsNotUsedAsValues, we need to use "verbatimModuleSyntax", which will require this package to be an ES Module.
-     */
-    "importsNotUsedAsValues": "error",
     "types": []
   },
 }
diff --git a/packages/icons/tsconfig.json b/packages/icons/tsconfig.json
@@ -1,20 +1,8 @@
 {
   "extends": "../ts/tsconfig.json",
   "compilerOptions": {
-    "strict": true,
     "allowJs": false,
     "noImplicitAny": true,
-    "noUnusedLocals": false,
-    "resolveJsonModule": true,
-    "experimentalDecorators": true,
-    "noUncheckedIndexedAccess": true,
-    "ignoreDeprecations": "5.0",
-    /* 
-     * TODO: remove importsNotUsedAsValues after typescript 5.5 and up as it will no longer work. If we want the same behavior
-     * as importsNotUsedAsValues, we need to use "verbatimModuleSyntax", which will require this package to be an ES Module.
-     */
-    "importsNotUsedAsValues": "error",
     "outDir": "dist",
-    "declaration": true
   },
 }
diff --git a/packages/launcher/tsconfig.json b/packages/launcher/tsconfig.json
@@ -5,7 +5,6 @@
     "./index.ts"
   ],
   "compilerOptions": {
-    "skipLibCheck": true
   },
   "files": [
     "./../ts/index.d.ts"

diff --git a/packages/reporter/tsconfig.json b/packages/reporter/tsconfig.json
@@ -1,7 +1,6 @@
 {
   "extends": "../ts/tsconfig.json",
   "compilerOptions": {
-    "useDefineForClassFields": true,
     "types": [
       "node",
       "cypress",

diff --git a/packages/scaffold-config/tsconfig.json b/packages/scaffold-config/tsconfig.json
@@ -10,19 +10,8 @@
   ],
   "compilerOptions": {
     "lib": ["esnext"],
-    "strict": true,
     "allowJs": false,
     "noImplicitAny": true,
-    "resolveJsonModule": true,
-    "experimentalDecorators": true,
-    "noUnusedLocals": false,
-    "noUncheckedIndexedAccess": true,
-    "ignoreDeprecations": "5.0",
-    /* 
-     * TODO: remove importsNotUsedAsValues after typescript 5.5 and up as it will no longer work. If we want the same behavior
-     * as importsNotUsedAsValues, we need to use "verbatimModuleSyntax", which will require this package to be an ES Module.
-     */
-    "importsNotUsedAsValues": "error",
     "types": []
   }
 }
diff --git a/packages/server/lib/automation/util.ts b/packages/server/lib/automation/util.ts
@@ -1,13 +1,15 @@
 import type playwright from 'playwright-webkit'
 import { domainMatch } from 'tough-cookie'
 
+// @ts-ignore
 export type CyCookie = Pick<chrome.cookies.Cookie, 'name' | 'value' | 'expirationDate' | 'hostOnly' | 'domain' | 'path' | 'secure' | 'httpOnly'> & {
   // use `undefined` instead of `unspecified`
   sameSite?: 'no_restriction' | 'lax' | 'strict'
 }
 
 // Cypress uses the webextension-style filtering
 // https://developer.chrome.com/extensions/cookies#method-getAll
+// @ts-ignore
 export type CyCookieFilter = chrome.cookies.GetAllDetails
 
 export const cookieMatches = (cookie: CyCookie | playwright.Cookie, filter: CyCookieFilter) => {

diff --git a/packages/server/lib/modes/interactive.ts b/packages/server/lib/modes/interactive.ts
@@ -125,6 +125,7 @@ export = {
         show: true,
         frame: true,
         transparent: false,
+        // @ts-ignore
         icon: image.createFromPath(cyIcons.getPathToIcon('icon_64x64.png')),
       },
     }

diff --git a/packages/server/tsconfig.json b/packages/server/tsconfig.json
@@ -9,12 +9,5 @@
   ],
   "compilerOptions": {
     "lib": ["esnext"],
-    "types": [
-      "mocha",
-      "node"
-    ],
-    "resolveJsonModule": true,
-    "noUnusedLocals": false,
-    "importHelpers": true
   }
 }
diff --git a/packages/socket/tsconfig.json b/packages/socket/tsconfig.json
@@ -1,7 +1,6 @@
 {
   "extends": "./../ts/tsconfig.json",
   "compilerOptions": {
-    "strict": true,
     "noImplicitAny": true,
     "skipLibCheck": false
   },

diff --git a/packages/telemetry/tsconfig.json b/packages/telemetry/tsconfig.json
@@ -4,13 +4,8 @@
   "compilerOptions": {
     "outDir": "./dist",
     "lib": ["esnext", "DOM"],
-    "strict": true,
     "allowJs": false,
     "noImplicitAny": true,
-    "resolveJsonModule": true,
-    "experimentalDecorators": true,
-    "noUnusedLocals": false,
-    "noUncheckedIndexedAccess": true,
     "types": ["cypress"],
   }
 }
diff --git a/packages/ts/README.md b/packages/ts/README.md
@@ -1,6 +1,6 @@
 # TS
 
-Internal package used to standardize this repo's version of `ts-node` used for development. In production we pre-transpile all of the typescript so this packages `register` export is a no-op
+Internal package used to standardize this repo's version of `ts-node` and the base `tsconfig` options used for development. In production we pre-transpile all of the typescript so this packages `register` export is a no-op
 
 ## Installing
 N/A - handled by the top level `yarn install`